Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Move No QA PRs to a separate section of the checklist #9905

Closed
roryabraham opened this issue Jul 14, 2022 · 5 comments
Closed

[HOLD] Move No QA PRs to a separate section of the checklist #9905

roryabraham opened this issue Jul 14, 2022 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Improvement Item broken or needs improvement. Monthly KSv2

Comments

@roryabraham
Copy link
Contributor

Problem

Sometimes our deploy checklists get very large. When there are many documentation, helpsite, or GitHub Actions PRs in the checklist, those PRs typically don't need any QA.

As a time-saver/QOL improvement for Applause and deployers, we automatically check off any PR on the checklist if the title is prefixed with [No QA].

However, in some cases such as this one, there are a ton of [No QA] PRs. This makes life more difficult for Applause and for the deployer, because they have to sift through many distracting checklist items to find the ones that they actually tested.

According to @isagoico:

Since we manually export the results it would be perfect to have all the ones that we actually executed in a single section

I've also experienced this problem in a different way – as a deployer I want to quickly be able to see any PRs that aren't resolved yet and which may be blocking deploy. When normal PRs are mixed in with a large list of PRs that didn't undergo QA, it takes longer.

Solution

Move [No QA] PRs to a separate section of the checklist, where they don't actually get checkboxes and instead are just listed out for audit/record-keeping/diff purposes.

@roryabraham roryabraham added Engineering Monthly KSv2 Improvement Item broken or needs improvement. labels Jul 14, 2022
@roryabraham roryabraham self-assigned this Jul 14, 2022
@roryabraham
Copy link
Contributor Author

Going to HOLD this on #9999

@roryabraham roryabraham changed the title Move No QA PRs to a separate section of the checklist [HOLD] Move No QA PRs to a separate section of the checklist Jul 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2022
@roryabraham
Copy link
Contributor Author

Still on HOLD. @mountiny would you be interested in taking this one from me and tackling it alongside #9999 ?

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2022
@mountiny
Copy link
Contributor

Might be good to do alongside, although quite scared of the refactor there, definitely a stuff to work on after the Offshore 😄

@mountiny mountiny assigned mountiny and unassigned roryabraham Aug 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2022
@mountiny
Copy link
Contributor

Working on higher level priorities still

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2022
@mountiny
Copy link
Contributor

Since the PR we hodl this on was closed as low priority, do you think we should still do this? I think it is nice to have but also it is easy for QA to just check it off the first time they see the check list.

I will close this for now and if we will come back to polishing the deploy checklist experience and refactor, we should look into this. @roryabraham reopen if you disagree.

@mountiny mountiny closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2022
@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants