From 3d392d6ea14a265885f4863e93181ee32a660d52 Mon Sep 17 00:00:00 2001 From: rory Date: Thu, 23 Feb 2023 17:12:59 -0800 Subject: [PATCH 1/6] Fix status bar not matching background on Android --- .../java/com/expensify/chat/MainActivity.java | 6 ++++++ android/app/src/main/res/values/styles.xml | 7 ++++++- .../CustomStatusBar/index.android.js | 18 ------------------ 3 files changed, 12 insertions(+), 19 deletions(-) delete mode 100644 src/components/CustomStatusBar/index.android.js diff --git a/android/app/src/main/java/com/expensify/chat/MainActivity.java b/android/app/src/main/java/com/expensify/chat/MainActivity.java index 24dcf36a177b..78bd2e4af28f 100644 --- a/android/app/src/main/java/com/expensify/chat/MainActivity.java +++ b/android/app/src/main/java/com/expensify/chat/MainActivity.java @@ -2,6 +2,8 @@ import android.os.Bundle; import android.content.pm.ActivityInfo; +import android.view.Window; +import android.view.WindowManager; import com.expensify.chat.bootsplash.BootSplash; import com.facebook.react.ReactActivity; import com.facebook.react.ReactActivityDelegate; @@ -52,6 +54,10 @@ protected boolean isConcurrentRootEnabled() { @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(null); + + Window w = getWindow(); + w.setFlags(WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS, WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS); + if (getResources().getBoolean(R.bool.portrait_only)) { setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT); } diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml index dbaeb878951e..7f7af78caade 100644 --- a/android/app/src/main/res/values/styles.xml +++ b/android/app/src/main/res/values/styles.xml @@ -6,7 +6,9 @@ @@ -16,6 +18,9 @@ @drawable/bootsplash false true + @android:color/transparent + @android:color/transparent + true diff --git a/src/components/CustomStatusBar/index.android.js b/src/components/CustomStatusBar/index.android.js deleted file mode 100644 index fa3f8921e82a..000000000000 --- a/src/components/CustomStatusBar/index.android.js +++ /dev/null @@ -1,18 +0,0 @@ -import React from 'react'; -import {StatusBar} from 'react-native'; -import themeColors from '../../styles/themes/default'; - -/** - * Only the Android platform supports "setBackgroundColor" - */ - -export default class CustomStatusBar extends React.Component { - componentDidMount() { - StatusBar.setBarStyle('light-content'); - StatusBar.setBackgroundColor(themeColors.appBG); - } - - render() { - return ; - } -} From a223dab28d9898029742e48ee2b006b8bdd13f2c Mon Sep 17 00:00:00 2001 From: rory Date: Thu, 23 Feb 2023 17:24:06 -0800 Subject: [PATCH 2/6] Add comment --- android/app/src/main/java/com/expensify/chat/MainActivity.java | 1 + 1 file changed, 1 insertion(+) diff --git a/android/app/src/main/java/com/expensify/chat/MainActivity.java b/android/app/src/main/java/com/expensify/chat/MainActivity.java index 78bd2e4af28f..6a9bc5dd89a0 100644 --- a/android/app/src/main/java/com/expensify/chat/MainActivity.java +++ b/android/app/src/main/java/com/expensify/chat/MainActivity.java @@ -55,6 +55,7 @@ protected boolean isConcurrentRootEnabled() { protected void onCreate(Bundle savedInstanceState) { super.onCreate(null); + // Make the app take up the full screen (painted behind transparent status bar) Window w = getWindow(); w.setFlags(WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS, WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS); From 6d4ee6c7915fc4e521f9dc69e4300f57a2518a52 Mon Sep 17 00:00:00 2001 From: rory Date: Fri, 24 Feb 2023 09:13:29 -0800 Subject: [PATCH 3/6] Remove redundant styles in BootTheme --- android/app/src/main/res/values/styles.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml index 7f7af78caade..08e8b3aceba8 100644 --- a/android/app/src/main/res/values/styles.xml +++ b/android/app/src/main/res/values/styles.xml @@ -18,9 +18,6 @@ @drawable/bootsplash false true - @android:color/transparent - @android:color/transparent - true From 776f1da7e858f2ea5a673d08a858ee42c073739f Mon Sep 17 00:00:00 2001 From: rory Date: Fri, 24 Feb 2023 09:51:10 -0800 Subject: [PATCH 4/6] Remove unnecessary styles from BootTheme --- android/app/src/main/res/values/styles.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml index 08e8b3aceba8..0f9aaa520798 100644 --- a/android/app/src/main/res/values/styles.xml +++ b/android/app/src/main/res/values/styles.xml @@ -16,8 +16,6 @@ From 37e720e974153d2184e3c09a0c2e1b30cab0cb5d Mon Sep 17 00:00:00 2001 From: rory Date: Fri, 24 Feb 2023 10:40:28 -0800 Subject: [PATCH 5/6] Fix black icons in status bar --- android/app/src/main/res/values/styles.xml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml index 0f9aaa520798..49196bd354ad 100644 --- a/android/app/src/main/res/values/styles.xml +++ b/android/app/src/main/res/values/styles.xml @@ -1,18 +1,17 @@ - - + +