From e4c985010b149f545ba36da5acf142a36f0f5987 Mon Sep 17 00:00:00 2001 From: Steven KKC Date: Thu, 3 Aug 2023 10:21:13 -0400 Subject: [PATCH 1/3] fix reply in thread does not have from link in header --- src/libs/ReportUtils.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js index 91c35d4cd956..714a2831053d 100644 --- a/src/libs/ReportUtils.js +++ b/src/libs/ReportUtils.js @@ -1356,12 +1356,12 @@ function getRootReportAndWorkspaceName(report) { if (isIOURequest(report)) { return { - rootReportName: lodashGet(report, 'displayName', ''), + rootReportName: getReportName(report), }; } if (isExpenseRequest(report)) { return { - rootReportName: lodashGet(report, 'displayName', ''), + rootReportName: getReportName(report), workspaceName: isIOUReport(report) ? CONST.POLICY.OWNER_EMAIL_FAKE : getPolicyName(report, true), }; } From d07e5c133608eba929a9c3973b1b8800bd552b85 Mon Sep 17 00:00:00 2001 From: Steven KKC Date: Fri, 4 Aug 2023 08:40:28 -0400 Subject: [PATCH 2/3] fix parentReportID prop type warning --- src/components/ParentNavigationSubtitle.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ParentNavigationSubtitle.js b/src/components/ParentNavigationSubtitle.js index fd388b00a8a7..6856dbffaa33 100644 --- a/src/components/ParentNavigationSubtitle.js +++ b/src/components/ParentNavigationSubtitle.js @@ -18,7 +18,7 @@ const propTypes = { }).isRequired, /** parent Report ID */ - parentReportID: PropTypes.string, + parentReportID: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), /** PressableWithoutFeedack additional styles */ // eslint-disable-next-line react/forbid-prop-types From cd4d7db70cbf53bd4db7435a3bfae974d7c4152a Mon Sep 17 00:00:00 2001 From: Steven KKC Date: Wed, 9 Aug 2023 15:07:21 -0400 Subject: [PATCH 3/3] revert last commit --- src/components/ParentNavigationSubtitle.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ParentNavigationSubtitle.js b/src/components/ParentNavigationSubtitle.js index 6856dbffaa33..fd388b00a8a7 100644 --- a/src/components/ParentNavigationSubtitle.js +++ b/src/components/ParentNavigationSubtitle.js @@ -18,7 +18,7 @@ const propTypes = { }).isRequired, /** parent Report ID */ - parentReportID: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), + parentReportID: PropTypes.string, /** PressableWithoutFeedack additional styles */ // eslint-disable-next-line react/forbid-prop-types