feat: update some package versions to avoid console warnings #27289

allroundexperts · 2023-09-12T19:57:31Z

Details

This PR fixes the console warnings which appeared because of some outdated packages.

Fixed Issues

Tests

Open the App.
Verify that the following console warnings do not show up:

[webpack-dev-server] WARNING in ./node_modules/react-native-performance/lib/module/NativeRNPerformanceManager.js

[webpack-dev-server] WARNING in ./node_modules/react-native-svg/lib/module/ReactNativeSVG.web.js

[webpack-dev-server] WARNING in ./src/libs/actions/Device/getDeviceInfo/getBaseInfo.js

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

I think this does not need a QA.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-13.at.12.37.25.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-13.at.12.41.14.AM.mov

Mobile Web - Safari

Screen.Recording.2023-09-13.at.12.42.27.AM.mov

Desktop

Screen.Recording.2023-09-13.at.12.48.07.AM.mov

iOS

Screen.Recording.2023-09-13.at.12.44.42.AM.mov

Android

Flipper wasn't connecting to android so I just posted a screenshot showing that app is running successfully.

melvin-bot · 2023-09-12T19:57:36Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-09-12T20:05:38Z

There is a Performance.js lib which will also need to be migrated and tested against the new version.

Thoughts on this?

allroundexperts · 2023-09-12T20:15:49Z

Thoughts on this?

I think that the version upgrade should not have any impact. I ran flipper on iOS without any issues after installing this. Similarly, I wasn't able to see any related console errors as well. Do you know of any other test cases which I should validate?

parasharrajat · 2023-09-12T20:38:51Z

Something is wrong, I can not run npm i. For the same reason, tests are failing here.

allroundexperts · 2023-09-12T20:39:56Z

Something is wrong, I can not run npm i. For the same reason, tests are failing here.

Hm... Let me check.

parasharrajat · 2023-09-12T21:41:34Z

@allroundexperts any luck

allroundexperts · 2023-09-12T21:42:38Z

Sorry, I got distracted with another task. I'll let you know once this is ready again.

allroundexperts · 2023-09-12T22:57:15Z

This is ready @parasharrajat

parasharrajat · 2023-09-13T06:30:35Z

What was the issue and how did you fix it?

allroundexperts · 2023-09-13T21:06:46Z

What was the issue and how did you fix it?

Hi @parasharrajat!
The issue was that I forgot to update the react-native-performance package version which was being used as a peer dependency for another package. This caused the npm i command to fail. You can check out the change I did here.

parasharrajat · 2023-09-14T00:24:38Z

Did you manually updated the lock file or with npm install?

allroundexperts · 2023-09-14T00:26:11Z

Did you manually updated the lock file or with npm install?

Manual. The specific version of react-native-performance was hard coded as a peer dependency.

parasharrajat · 2023-09-14T00:32:23Z

When you say it was hardcoded, hardcoded where?

Lock file is generated automatically and we should not manually change it. If some package in the app is using old peer dependency, we should be upgrading that or do something to fix the peer dependency.

allroundexperts · 2023-09-14T00:44:03Z

When you say it was hardcoded, hardcoded where?

Lock file is generated automatically and we should not manually change it. If some package in the app is using old peer dependency, we should be upgrading that or do something to fix the peer dependency.

I think you are correct. The version 4.0.0 of react-native-performance was a peer dependency of react-native-onyx. Did not realise that react-native-onyx is a library we maintained.

I'll create a PR on that repository, updating the version.

parasharrajat · 2023-09-14T00:46:06Z

Thanks. Let me know when it's ready.

allroundexperts · 2023-09-14T00:50:14Z

@parasharrajat Expensify/react-native-onyx#340

allroundexperts · 2023-09-14T13:33:17Z

@parasharrajat The react-native-onyx bump was merged and I incorporated it into this PR. This is ready for testing again!

parasharrajat · 2023-09-15T10:48:08Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-09-15.at.4.43.44.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-09-15.at.4.41.07.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-09-15.at.5.09.27.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-09-15.at.4.37.00.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-09-15.at.4.45.08.PM.mov

🔲 Android / native

Screen.Recording.2023-09-15.at.5.10.42.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2023-09-18T02:28:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-18T10:39:36Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan

There's Podfile.lock file diff on latest main, caused by this PR.
Can anyone please raise follow-up PR?

parasharrajat · 2023-09-18T14:22:24Z

ah, I didn't notice. I can do that.

parasharrajat · 2023-09-18T14:28:00Z

here we go #27681.

OSBotify · 2023-09-20T08:12:06Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

feat: update some package versions to avoid console warnings

71fc6c1

allroundexperts requested a review from a team as a code owner September 12, 2023 19:57

melvin-bot bot requested review from parasharrajat and removed request for a team September 12, 2023 19:57

fix: lint errors

34afbb6

allroundexperts mentioned this pull request Sep 12, 2023

[HOLD for payment 2023-09-27] [$500] webpack-dev-server warnings show in JS console #26987

Closed

allroundexperts mentioned this pull request Sep 14, 2023

feat: bump the peer dependency version of react-native-performance Expensify/react-native-onyx#340

Merged

feat: bump react-native-onyx version

bf499d3

allroundexperts force-pushed the fix-26987 branch from 7c0dfa0 to bf499d3 Compare September 14, 2023 13:26

merge with main

fd31314

parasharrajat approved these changes Sep 15, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf September 15, 2023 11:42

marcochavezf approved these changes Sep 18, 2023

View reviewed changes

marcochavezf merged commit 225fddc into Expensify:main Sep 18, 2023

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

situchan reviewed Sep 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update some package versions to avoid console warnings #27289

feat: update some package versions to avoid console warnings #27289

allroundexperts commented Sep 12, 2023 •

edited

Loading

melvin-bot bot commented Sep 12, 2023

parasharrajat commented Sep 12, 2023

allroundexperts commented Sep 12, 2023

parasharrajat commented Sep 12, 2023 •

edited

Loading

allroundexperts commented Sep 12, 2023

parasharrajat commented Sep 12, 2023

allroundexperts commented Sep 12, 2023

allroundexperts commented Sep 12, 2023

parasharrajat commented Sep 13, 2023

allroundexperts commented Sep 13, 2023

parasharrajat commented Sep 14, 2023 •

edited

Loading

allroundexperts commented Sep 14, 2023

parasharrajat commented Sep 14, 2023

allroundexperts commented Sep 14, 2023

parasharrajat commented Sep 14, 2023

allroundexperts commented Sep 14, 2023

allroundexperts commented Sep 14, 2023

parasharrajat commented Sep 15, 2023 •

edited

Loading

parasharrajat left a comment

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

situchan left a comment

parasharrajat commented Sep 18, 2023

parasharrajat commented Sep 18, 2023

OSBotify commented Sep 20, 2023

feat: update some package versions to avoid console warnings #27289

feat: update some package versions to avoid console warnings #27289

Conversation

allroundexperts commented Sep 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 12, 2023

parasharrajat commented Sep 12, 2023

allroundexperts commented Sep 12, 2023

parasharrajat commented Sep 12, 2023 • edited Loading

allroundexperts commented Sep 12, 2023

parasharrajat commented Sep 12, 2023

allroundexperts commented Sep 12, 2023

allroundexperts commented Sep 12, 2023

parasharrajat commented Sep 13, 2023

allroundexperts commented Sep 13, 2023

parasharrajat commented Sep 14, 2023 • edited Loading

allroundexperts commented Sep 14, 2023

parasharrajat commented Sep 14, 2023

allroundexperts commented Sep 14, 2023

parasharrajat commented Sep 14, 2023

allroundexperts commented Sep 14, 2023

allroundexperts commented Sep 14, 2023

parasharrajat commented Sep 15, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

situchan left a comment

Choose a reason for hiding this comment

parasharrajat commented Sep 18, 2023

parasharrajat commented Sep 18, 2023

OSBotify commented Sep 20, 2023

allroundexperts commented Sep 12, 2023 •

edited

Loading

parasharrajat commented Sep 12, 2023 •

edited

Loading

parasharrajat commented Sep 14, 2023 •

edited

Loading

parasharrajat commented Sep 15, 2023 •

edited

Loading