Fix/26409: Reset confirmation modal if accountIDs changed #27411

DylanDylann · 2023-09-14T05:27:19Z

Details

The delete confirmation modal should be closed if accountIDs changed. This PR does that

Fixed Issues

$ #26409
PROPOSAL: #26409 (comment)

Tests

Navigate to Settings > Workspace > New workspace.
Go to the Members section.

Original Bug

Invite a member to the workspace.
Select the member and click on "Remove."
Copy the URL and paste it into another tab.
In the new tab, remove the member.
Return to the previous tab.
Verify that the delete confirmation modal is closed

Additional Bug 1
3. Go offline
4. Invite a member (not exist yet like "qweqwe@gmail.com") to the workspace.
5. Select the member and click on "Remove."
6. Go online
7. Verify that the delete confirmation modal is closed

Additional Bug 2
3. Go offline
4. Invite a member (who we chatted before) to the workspace.
5. Select the member and click on "Remove."
6. Go online
7. Verify that the delete confirmation modal still remained

Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to Settings > Workspace > New workspace.
Go to the Members section.

Original Bug (only reproduce on WEB)

Invite a member to the workspace.
Select the member and click on "Remove."
Copy the URL and paste it into another tab.
In the new tab, remove the member.
Return to the previous tab.
Verify that the delete confirmation modal is closed

Additional Bug 1
3. Go offline
4. Invite a member (not exist yet like "qweqwe@gmail.com") to the workspace.
5. Select the member and click on "Remove."
6. Go online
7. Verify that the delete confirmation modal is closed

Additional Bug 2
3. Go offline
4. Invite a member (who we chatted before) to the workspace.
5. Select the member and click on "Remove."
6. Go online
7. Verify that the delete confirmation modal still remained

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

OP Bug
https://github.com/Expensify/App/assets/141406735/49ca9dfb-0fb8-4807-8597-1615cf39830c

Additional Bug
https://github.com/Expensify/App/assets/141406735/eee29fdc-25ae-42fb-b2bf-3d8ea1b2be73

Mobile Web - Chrome

Screen.Recording.2023-09-14.at.13.22.54.1.mp4

Mobile Web - Safari

Screen.Recording.2023-09-14.at.13.09.10.1.mp4

Desktop

OP Bug
https://github.com/Expensify/App/assets/141406735/288cbff9-9c9e-4aad-8214-3d7e3928d796

Additional Bug
https://github.com/Expensify/App/assets/141406735/34bc4754-2d98-4880-84c6-b216eb84ba43

iOS

Screen.Recording.2023-09-14.at.15.57.08.mp4

Android

Screen.Recording.2023-09-14.at.16.10.42.mp4

melvin-bot · 2023-09-14T09:07:16Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr

A question and some cleanup.

mollfpr · 2023-09-14T13:59:20Z

src/pages/workspace/WorkspaceMembersPage.js

@@ -107,8 +107,12 @@ function WorkspaceMembersPage(props) {
    useEffect(() => {
        validateSelection();
    }, [props.preferredLocale, validateSelection]);
-
+    const accountIDs = useMemo(() => _.keys(props.policyMembers), [props.policyMembers]);


Whats the reason to use useMemo here?

@mollfpr accountIDs is calculated from policyMembers so I put it in useMemo to avoid re-calculate it. But if you see it is unnecessary we can remove useMemo

@DylanDylann I guess we can keep it. It make sense.

src/pages/workspace/WorkspaceMembersPage.js

DylanDylann · 2023-09-15T12:14:05Z

@mollfpr Bump

mollfpr · 2023-09-15T14:53:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

27411.Web.mp4

27411.Web.2.mp4

Mobile Web - Chrome

27411.mweb-chrome.mp4

27411.mweb-chrome.2.mp4

Mobile Web - Safari

27411.mWeb.Safari.mp4

27411.mWeb-Safari.2.mp4

Desktop

27411.Desktop.mp4

27411.Desktop.2.mp4

iOS

27411.iOS.mp4

27411.iOS.2.mp4

Android

27411.Android.mp4

27411.Android.2.mp4

mollfpr

LGTM and tests well 👍

johnmlee101

LGTM!

OSBotify · 2023-09-18T03:04:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-18T10:39:24Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-20T08:11:54Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

DylanDylann added 2 commits September 14, 2023 12:25

reset modal if accountIDs changed

f480398

add import

beefbef

DylanDylann marked this pull request as ready for review September 14, 2023 09:07

DylanDylann requested a review from a team as a code owner September 14, 2023 09:07

melvin-bot bot requested review from mollfpr and removed request for a team September 14, 2023 09:07

mollfpr reviewed Sep 14, 2023

View reviewed changes

DylanDylann added 2 commits September 14, 2023 23:45

make code cleaner

0d52b9d

fix lint

f33af5c

mollfpr approved these changes Sep 15, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 September 15, 2023 17:24

johnmlee101 approved these changes Sep 18, 2023

View reviewed changes

johnmlee101 merged commit 203f79c into Expensify:main Sep 18, 2023

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

melvin-bot bot mentioned this pull request Sep 20, 2023

[HOLD for payment 2023-09-27] [$500] Web - The delete confirmation modal fails to close when removing a member from another tab #26409

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/26409: Reset confirmation modal if accountIDs changed #27411

Fix/26409: Reset confirmation modal if accountIDs changed #27411

DylanDylann commented Sep 14, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023

mollfpr left a comment

mollfpr Sep 14, 2023

DylanDylann Sep 14, 2023

mollfpr Sep 15, 2023

DylanDylann commented Sep 15, 2023

mollfpr commented Sep 15, 2023 •

edited

Loading

mollfpr left a comment

johnmlee101 left a comment

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

Fix/26409: Reset confirmation modal if accountIDs changed #27411

Fix/26409: Reset confirmation modal if accountIDs changed #27411

Conversation

DylanDylann commented Sep 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr Sep 14, 2023

Choose a reason for hiding this comment

DylanDylann Sep 14, 2023

Choose a reason for hiding this comment

mollfpr Sep 15, 2023

Choose a reason for hiding this comment

DylanDylann commented Sep 15, 2023

mollfpr commented Sep 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

johnmlee101 left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

DylanDylann commented Sep 14, 2023 •

edited

Loading

mollfpr commented Sep 15, 2023 •

edited

Loading