From f43c46746bdc9d5a7b163d0e6d760090834590a8 Mon Sep 17 00:00:00 2001 From: mkhutornyi Date: Mon, 18 Dec 2023 18:41:08 +0100 Subject: [PATCH 1/2] fix button icon style in light theme --- src/components/Button/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Button/index.tsx b/src/components/Button/index.tsx index af8ec33683de..b254ccfaa85f 100644 --- a/src/components/Button/index.tsx +++ b/src/components/Button/index.tsx @@ -221,7 +221,7 @@ function Button( @@ -232,7 +232,7 @@ function Button( From 6ac7f1d6a2dd09c2cfae9a82351b560f0d8c4209 Mon Sep 17 00:00:00 2001 From: mkhutornyi Date: Wed, 20 Dec 2023 16:46:17 -0500 Subject: [PATCH 2/2] fix crash when trying to scroll pdf preview --- .../AttachmentView/AttachmentViewPdf/BaseAttachmentViewPdf.js | 2 +- .../AttachmentView/AttachmentViewPdf/index.android.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Attachments/AttachmentView/AttachmentViewPdf/BaseAttachmentViewPdf.js b/src/components/Attachments/AttachmentView/AttachmentViewPdf/BaseAttachmentViewPdf.js index 40887ddee697..de14f848c37e 100644 --- a/src/components/Attachments/AttachmentView/AttachmentViewPdf/BaseAttachmentViewPdf.js +++ b/src/components/Attachments/AttachmentView/AttachmentViewPdf/BaseAttachmentViewPdf.js @@ -30,7 +30,7 @@ function BaseAttachmentViewPdf({ onScaleChangedProp(scale); // When a pdf is shown in a carousel, we want to disable the pager scroll when the pdf is zoomed in - if (isUsedInCarousel) { + if (isUsedInCarousel && attachmentCarouselPagerContext) { const shouldPagerScroll = scale === 1; attachmentCarouselPagerContext.onPinchGestureChange(!shouldPagerScroll); diff --git a/src/components/Attachments/AttachmentView/AttachmentViewPdf/index.android.js b/src/components/Attachments/AttachmentView/AttachmentViewPdf/index.android.js index 308d3cf2c0ba..6d510d234512 100644 --- a/src/components/Attachments/AttachmentView/AttachmentViewPdf/index.android.js +++ b/src/components/Attachments/AttachmentView/AttachmentViewPdf/index.android.js @@ -18,7 +18,7 @@ function AttachmentViewPdf(props) { const Pan = Gesture.Pan() .manualActivation(true) .onTouchesMove((evt) => { - if (offsetX.value !== 0 && offsetY.value !== 0) { + if (offsetX.value !== 0 && offsetY.value !== 0 && attachmentCarouselPagerContext) { // if the value of X is greater than Y and the pdf is not zoomed in, // enable the pager scroll so that the user // can swipe to the next attachment otherwise disable it.