From b7cdaf83cbf947f9566005bca083f08e1a0047b9 Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 12 Apr 2024 04:04:11 +0700
Subject: [PATCH 01/12] feat: surfacing potential duplicates

---
 src/components/HoldBanner.tsx         | 11 +++++--
 src/components/MoneyRequestHeader.tsx | 29 +++++++++++++++--
 src/languages/en.ts                   |  2 ++
 src/languages/es.ts                   |  2 ++
 src/libs/Permissions.ts               |  2 +-
 src/libs/TransactionUtils.ts          | 47 +++++++++++++++++++++++++--
 src/types/onyx/Transaction.ts         |  2 ++
 7 files changed, 87 insertions(+), 8 deletions(-)

diff --git a/src/components/HoldBanner.tsx b/src/components/HoldBanner.tsx
index af77d9076629..5376087ba849 100644
--- a/src/components/HoldBanner.tsx
+++ b/src/components/HoldBanner.tsx
@@ -5,14 +5,19 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import Text from './Text';
 import TextPill from './TextPill';
 
-function HoldBanner() {
+type HoldBannerProps = {
+    isRequestDuplicate?: boolean;
+    shouldShowBorderBottom?: boolean;
+};
+
+function HoldBanner({isRequestDuplicate = false, shouldShowBorderBottom = false}: HoldBannerProps) {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
 
     return (
-        <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pb3, styles.ph5, styles.borderBottom]}>
+        <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pb3, styles.ph5, shouldShowBorderBottom ? styles.borderBottom : {}]}>
             <TextPill>{translate('iou.hold')}</TextPill>
-            <Text style={[styles.textLabel, styles.pl3, styles.mw100, styles.flexShrink1]}>{translate('iou.requestOnHold')}</Text>
+            <Text style={[styles.textLabel, styles.pl3, styles.mw100, styles.flexShrink1]}>{isRequestDuplicate ? translate('iou.requestDuplicate') : translate('iou.requestOnHold')}</Text>
         </View>
     );
 }
diff --git a/src/components/MoneyRequestHeader.tsx b/src/components/MoneyRequestHeader.tsx
index f451f5f15581..6588b8167e62 100644
--- a/src/components/MoneyRequestHeader.tsx
+++ b/src/components/MoneyRequestHeader.tsx
@@ -16,6 +16,7 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type {Policy, Report, ReportAction, ReportActions, Session, Transaction} from '@src/types/onyx';
 import type {OriginalMessageIOU} from '@src/types/onyx/OriginalMessage';
+import Button from './Button';
 import ConfirmModal from './ConfirmModal';
 import HeaderWithBackButton from './HeaderWithBackButton';
 import HoldBanner from './HoldBanner';
@@ -61,6 +62,7 @@ function MoneyRequestHeader({session, parentReport, report, parentReportAction,
     const isSettled = ReportUtils.isSettled(moneyRequestReport?.reportID);
     const isApproved = ReportUtils.isReportApproved(moneyRequestReport);
     const isOnHold = TransactionUtils.isOnHold(transaction);
+    const isDuplicate = TransactionUtils.isDuplicate(transaction?.transactionID ?? '');
     const {isSmallScreenWidth, windowWidth} = useWindowDimensions();
 
     // Only the requestor can take delete the request, admins can only edit it.
@@ -178,7 +180,15 @@ function MoneyRequestHeader({session, parentReport, report, parentReportAction,
                     policy={policy}
                     shouldShowBackButton={isSmallScreenWidth}
                     onBackButtonPress={() => Navigation.goBack(undefined, false, true)}
-                />
+                >
+                    {isDuplicate && !isSmallScreenWidth && (
+                        <Button
+                            success
+                            medium
+                            text={translate('iou.reviewDuplicates')}
+                        />
+                    )}
+                </HeaderWithBackButton>
                 {isPending && (
                     <MoneyRequestHeaderStatusBar
                         title={translate('iou.pending')}
@@ -193,7 +203,22 @@ function MoneyRequestHeader({session, parentReport, report, parentReportAction,
                         shouldShowBorderBottom
                     />
                 )}
-                {isOnHold && <HoldBanner />}
+                {isOnHold && (
+                    <HoldBanner
+                        isRequestDuplicate={isDuplicate}
+                        shouldShowBorderBottom={!isDuplicate || !isSmallScreenWidth}
+                    />
+                )}
+                {isDuplicate && isSmallScreenWidth && (
+                    <View style={[styles.ph5, styles.pb2, styles.borderBottom]}>
+                        <Button
+                            success
+                            medium
+                            text={translate('iou.reviewDuplicates')}
+                            style={[styles.w100, styles.pr0]}
+                        />
+                    </View>
+                )}
             </View>
             <ConfirmModal
                 title={translate('iou.deleteRequest')}
diff --git a/src/languages/en.ts b/src/languages/en.ts
index d9c96e51ed64..d73993548ce9 100755
--- a/src/languages/en.ts
+++ b/src/languages/en.ts
@@ -720,6 +720,8 @@ export default {
         reason: 'Reason',
         holdReasonRequired: 'A reason is required when holding.',
         requestOnHold: 'This request was put on hold. Review the comments for next steps.',
+        requestDuplicate: 'This request has the same details as another one. Review the duplicated to remove the hold.',
+        reviewDuplicates: 'Review duplicates',
         confirmApprove: 'Confirm what to approve',
         confirmApprovalAmount: 'Approve the entire report total or only the amount not on hold.',
         confirmPay: 'Confirm what to pay',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index f6c649fdac72..2c7955ee8116 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -717,6 +717,8 @@ export default {
         reason: 'Razón',
         holdReasonRequired: 'Se requiere una razón para bloquear.',
         requestOnHold: 'Este solicitud está bloqueada. Revisa los comentarios para saber como proceder.',
+        requestDuplicate: 'Esta solicitud tiene los mismos detalles que otra. Revise el duplicado para eliminar la retención.',
+        reviewDuplicates: 'Revisar duplicados',
         confirmApprove: 'Confirma que quieres aprobar',
         confirmApprovalAmount: 'Aprobar el total o solo la parte no bloqueada.',
         confirmPay: 'Confirma que quieres pagar',
diff --git a/src/libs/Permissions.ts b/src/libs/Permissions.ts
index 105736faeba0..9cc91b8ea176 100644
--- a/src/libs/Permissions.ts
+++ b/src/libs/Permissions.ts
@@ -4,7 +4,7 @@ import type {IOUType} from '@src/CONST';
 import type Beta from '@src/types/onyx/Beta';
 
 function canUseAllBetas(betas: OnyxEntry<Beta[]>): boolean {
-    return !!betas?.includes(CONST.BETAS.ALL);
+    return true;
 }
 
 function canUseChronos(betas: OnyxEntry<Beta[]>): boolean {
diff --git a/src/libs/TransactionUtils.ts b/src/libs/TransactionUtils.ts
index 9c398998588e..598f6ed89943 100644
--- a/src/libs/TransactionUtils.ts
+++ b/src/libs/TransactionUtils.ts
@@ -5,7 +5,7 @@ import type {ValueOf} from 'type-fest';
 import CONST from '@src/CONST';
 import type {TranslationPaths} from '@src/languages/types';
 import ONYXKEYS from '@src/ONYXKEYS';
-import type {RecentWaypoint, Report, TaxRate, TaxRates, TaxRatesWithDefault, Transaction, TransactionViolation} from '@src/types/onyx';
+import type {RecentWaypoint, Report, TaxRate, TaxRates, TaxRatesWithDefault, Transaction, TransactionViolation, TransactionViolations} from '@src/types/onyx';
 import type {Comment, Receipt, TransactionChanges, TransactionPendingFieldsKey, Waypoint, WaypointCollection} from '@src/types/onyx/Transaction';
 import {isEmptyObject} from '@src/types/utils/EmptyObject';
 import type {IOURequestType} from './actions/IOU';
@@ -35,6 +35,30 @@ Onyx.connect({
     callback: (value) => (allReports = value),
 });
 
+let allTransactionViolations: NonNullable<OnyxCollection<TransactionViolations>> = {};
+Onyx.connect({
+    key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
+    waitForCollectionCallback: true,
+    callback: (value) => {
+        if (!value) {
+            allTransactionViolations = {};
+            return;
+        }
+
+        allTransactionViolations = value;
+    },
+});
+
+let currentUserEmail = '';
+let currentUserAccountID = -1;
+Onyx.connect({
+    key: ONYXKEYS.SESSION,
+    callback: (val) => {
+        currentUserEmail = val?.email ?? '';
+        currentUserAccountID = val?.accountID ?? -1;
+    },
+});
+
 function isDistanceRequest(transaction: OnyxEntry<Transaction>): boolean {
     // This is used during the request creation flow before the transaction has been saved to the server
     if (lodashHas(transaction, 'iouRequestType')) {
@@ -591,6 +615,24 @@ function getRecentTransactions(transactions: Record<string, string>, size = 2):
         .slice(0, size);
 }
 
+/**
+ * Check if transaction has duplicatedTransaction violation.
+ * @param transactionID - the transaction to check
+ * @param checkDismissed - whether to check if the violation has already been dismissed as well
+ */
+function isDuplicate(transactionID: string, checkDismissed = false): boolean {
+    return true;
+    const hasDuplicatedViolation = !!allTransactionViolations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`]?.some(
+        (violation: TransactionViolation) => violation.type === CONST.VIOLATIONS.DUPLICATED_TRANSACTION,
+    );
+    if (!checkDismissed) {
+        return hasDuplicatedViolation;
+    }
+    const didDismissedViolation =
+        allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]?.comment?.dismissedViolations?.duplicatedTransaction?.[currentUserEmail] === `${currentUserAccountID}`;
+    return hasDuplicatedViolation && !didDismissedViolation;
+}
+
 /**
  * Check if transaction is on hold
  */
@@ -599,7 +641,7 @@ function isOnHold(transaction: OnyxEntry<Transaction>): boolean {
         return false;
     }
 
-    return !!transaction.comment?.hold;
+    return !!transaction.comment?.hold || isDuplicate(transaction?.transactionID, true);
 }
 
 /**
@@ -687,6 +729,7 @@ export {
     isFetchingWaypointsFromServer,
     isExpensifyCardTransaction,
     isCardTransaction,
+    isDuplicate,
     isPending,
     isPosted,
     isOnHold,
diff --git a/src/types/onyx/Transaction.ts b/src/types/onyx/Transaction.ts
index 281b6b4228ce..11fce9e860d6 100644
--- a/src/types/onyx/Transaction.ts
+++ b/src/types/onyx/Transaction.ts
@@ -6,6 +6,7 @@ import type CollectionDataSet from '@src/types/utils/CollectionDataSet';
 import type {Participant, Split} from './IOU';
 import type * as OnyxCommon from './OnyxCommon';
 import type RecentWaypoint from './RecentWaypoint';
+import {ViolationName} from './TransactionViolation';
 
 type Waypoint = {
     /** The name associated with the address of the waypoint */
@@ -51,6 +52,7 @@ type Comment = {
     source?: string;
     originalTransactionID?: string;
     splits?: Split[];
+    dismissedViolations?: Record<ViolationName, Record<string, string>>;
 };
 
 type GeometryType = 'LineString';

From 513909a01b9551c6987c890af530a9cf98ea547d Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 12 Apr 2024 04:07:18 +0700
Subject: [PATCH 02/12] revert mistake changes

---
 src/libs/Permissions.ts       | 2 +-
 src/types/onyx/Transaction.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libs/Permissions.ts b/src/libs/Permissions.ts
index 9cc91b8ea176..105736faeba0 100644
--- a/src/libs/Permissions.ts
+++ b/src/libs/Permissions.ts
@@ -4,7 +4,7 @@ import type {IOUType} from '@src/CONST';
 import type Beta from '@src/types/onyx/Beta';
 
 function canUseAllBetas(betas: OnyxEntry<Beta[]>): boolean {
-    return true;
+    return !!betas?.includes(CONST.BETAS.ALL);
 }
 
 function canUseChronos(betas: OnyxEntry<Beta[]>): boolean {
diff --git a/src/types/onyx/Transaction.ts b/src/types/onyx/Transaction.ts
index 11fce9e860d6..ba3ebe03618f 100644
--- a/src/types/onyx/Transaction.ts
+++ b/src/types/onyx/Transaction.ts
@@ -6,7 +6,7 @@ import type CollectionDataSet from '@src/types/utils/CollectionDataSet';
 import type {Participant, Split} from './IOU';
 import type * as OnyxCommon from './OnyxCommon';
 import type RecentWaypoint from './RecentWaypoint';
-import {ViolationName} from './TransactionViolation';
+import type {ViolationName} from './TransactionViolation';
 
 type Waypoint = {
     /** The name associated with the address of the waypoint */

From 369585f65169fd322351716d9eca3b888f7649af Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Tue, 16 Apr 2024 03:39:20 +0700
Subject: [PATCH 03/12] modify copy

---
 src/languages/en.ts          | 2 +-
 src/languages/es.ts          | 2 +-
 src/libs/TransactionUtils.ts | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/languages/en.ts b/src/languages/en.ts
index 70ec07f9da1c..8c22bcedb0fa 100755
--- a/src/languages/en.ts
+++ b/src/languages/en.ts
@@ -719,7 +719,7 @@ export default {
         reason: 'Reason',
         holdReasonRequired: 'A reason is required when holding.',
         requestOnHold: 'This request was put on hold. Review the comments for next steps.',
-        requestDuplicate: 'This request has the same details as another one. Review the duplicated to remove the hold.',
+        requestDuplicate: 'This request has the same details as another one. Review the duplicates to remove the hold.',
         reviewDuplicates: 'Review duplicates',
         confirmApprove: 'Confirm what to approve',
         confirmApprovalAmount: 'Approve the entire report total or only the amount not on hold.',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index c16a150e713d..4b45bdea2c49 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -716,7 +716,7 @@ export default {
         reason: 'Razón',
         holdReasonRequired: 'Se requiere una razón para bloquear.',
         requestOnHold: 'Este solicitud está bloqueada. Revisa los comentarios para saber como proceder.',
-        requestDuplicate: 'Esta solicitud tiene los mismos detalles que otra. Revise el duplicado para eliminar la retención.',
+        requestDuplicate: 'Esta solicitud tiene los mismos detalles que otra. Revise los duplicados para eliminar la retención.',
         reviewDuplicates: 'Revisar duplicados',
         confirmApprove: 'Confirma que quieres aprobar',
         confirmApprovalAmount: 'Aprobar el total o solo la parte no bloqueada.',
diff --git a/src/libs/TransactionUtils.ts b/src/libs/TransactionUtils.ts
index 5bd66dc12558..0612d3d3cb6f 100644
--- a/src/libs/TransactionUtils.ts
+++ b/src/libs/TransactionUtils.ts
@@ -621,7 +621,6 @@ function getRecentTransactions(transactions: Record<string, string>, size = 2):
  * @param checkDismissed - whether to check if the violation has already been dismissed as well
  */
 function isDuplicate(transactionID: string, checkDismissed = false): boolean {
-    return true;
     const hasDuplicatedViolation = !!allTransactionViolations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`]?.some(
         (violation: TransactionViolation) => violation.type === CONST.VIOLATIONS.DUPLICATED_TRANSACTION,
     );

From 20b404839b6337de2288de85771a1b3216bd75ee Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 19 Apr 2024 20:23:40 +0700
Subject: [PATCH 04/12] show RBR on violation preview

---
 src/libs/ReportUtils.ts      |  4 ++--
 src/libs/TransactionUtils.ts | 12 +++++++++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
index a15e1937dbe2..a7c90b3e3ca5 100644
--- a/src/libs/ReportUtils.ts
+++ b/src/libs/ReportUtils.ts
@@ -4574,7 +4574,7 @@ function shouldHideReport(report: OnyxEntry<Report>, currentReportId: string): b
 }
 
 /**
- * Checks to see if a report's parentAction is an expense that contains a violation
+ * Checks to see if a report's parentAction is an expense that contains a violation type of either violation or warning
  */
 function doesTransactionThreadHaveViolations(report: OnyxEntry<Report>, transactionViolations: OnyxCollection<TransactionViolation[]>, parentReportAction: OnyxEntry<ReportAction>): boolean {
     if (parentReportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.IOU) {
@@ -4590,7 +4590,7 @@ function doesTransactionThreadHaveViolations(report: OnyxEntry<Report>, transact
     if (report?.stateNum !== CONST.REPORT.STATE_NUM.OPEN && report?.stateNum !== CONST.REPORT.STATE_NUM.SUBMITTED) {
         return false;
     }
-    return TransactionUtils.hasViolation(IOUTransactionID, transactionViolations);
+    return TransactionUtils.hasViolation(IOUTransactionID, transactionViolations) || TransactionUtils.hasWarning(IOUTransactionID, transactionViolations);
 }
 
 /**
diff --git a/src/libs/TransactionUtils.ts b/src/libs/TransactionUtils.ts
index 60b2a03f8ea0..33164c4a28b3 100644
--- a/src/libs/TransactionUtils.ts
+++ b/src/libs/TransactionUtils.ts
@@ -620,7 +620,7 @@ function getRecentTransactions(transactions: Record<string, string>, size = 2):
  */
 function isDuplicate(transactionID: string, checkDismissed = false): boolean {
     const hasDuplicatedViolation = !!allTransactionViolations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`]?.some(
-        (violation: TransactionViolation) => violation.type === CONST.VIOLATIONS.DUPLICATED_TRANSACTION,
+        (violation: TransactionViolation) => violation.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION,
     );
     if (!checkDismissed) {
         return hasDuplicatedViolation;
@@ -650,6 +650,15 @@ function hasViolation(transactionID: string, transactionViolations: OnyxCollecti
     );
 }
 
+/**
+ * Checks if any violations for the provided transaction are of type 'warning'
+ */
+function hasWarning(transactionID: string, transactionViolations: OnyxCollection<TransactionViolation[]>): boolean {
+    return Boolean(
+        transactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + transactionID]?.some((violation: TransactionViolation) => violation.type === CONST.VIOLATION_TYPES.WARNING),
+    );
+}
+
 function getTransactionViolations(transactionID: string, transactionViolations: OnyxCollection<TransactionViolation[]>): TransactionViolation[] | null {
     return transactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + transactionID] ?? null;
 }
@@ -742,6 +751,7 @@ export {
     waypointHasValidAddress,
     getRecentTransactions,
     hasViolation,
+    hasWarning,
 };
 
 export type {TransactionChanges};

From 4a6a2853b9d1de2409239a3ac44d087dd96f50fe Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 26 Apr 2024 02:19:16 +0700
Subject: [PATCH 05/12] show hold message on iou preview

---
 .../MoneyRequestPreviewContent.tsx                    | 11 ++++++++---
 src/languages/en.ts                                   |  2 +-
 src/languages/es.ts                                   |  2 +-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx b/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx
index 7f70a3e538a9..78312c69b4a4 100644
--- a/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx
+++ b/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx
@@ -97,6 +97,7 @@ function MoneyRequestPreviewContent({
     const isDeleted = action?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
     const shouldShowRBR =
         hasViolations || hasFieldErrors || (!(isSettled && !isSettlementOrApprovalPartial) && !(ReportUtils.isReportApproved(iouReport) && !isSettlementOrApprovalPartial) && isOnHold);
+    const shouldShowHoldMessage = !(isSettled && !isSettlementOrApprovalPartial) && isOnHold;
 
     /*
      Show the merchant for IOUs and expenses only if:
@@ -164,7 +165,11 @@ function MoneyRequestPreviewContent({
                 const isTooLong = violationsCount > 1 || violationMessage.length > 15;
                 const hasViolationsAndFieldErrors = violationsCount > 0 && hasFieldErrors;
 
-                return `${message} ${CONST.DOT_SEPARATOR} ${isTooLong || hasViolationsAndFieldErrors ? translate('violations.reviewRequired') : violationMessage}`;
+                message += ` ${CONST.DOT_SEPARATOR} ${isTooLong || hasViolationsAndFieldErrors ? translate('violations.reviewRequired') : violationMessage}`;
+                if (shouldShowHoldMessage) {
+                    message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.hold')}`;
+                }
+                return message;
             }
 
             const isMerchantMissing = TransactionUtils.isMerchantMissing(transaction);
@@ -175,7 +180,7 @@ function MoneyRequestPreviewContent({
                 message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.missingAmount')}`;
             } else if (isMerchantMissing) {
                 message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.missingMerchant')}`;
-            } else if (!(isSettled && !isSettlementOrApprovalPartial) && isOnHold) {
+            } else if (shouldShowHoldMessage) {
                 message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.hold')}`;
             }
         } else if (ReportUtils.isPaidGroupPolicyExpenseReport(iouReport) && ReportUtils.isReportApproved(iouReport) && !ReportUtils.isSettled(iouReport?.reportID) && !isPartialHold) {
@@ -184,7 +189,7 @@ function MoneyRequestPreviewContent({
             message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.pending')}`;
         } else if (iouReport?.isCancelledIOU) {
             message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.canceled')}`;
-        } else if (!(isSettled && !isSettlementOrApprovalPartial) && isOnHold) {
+        } else if (shouldShowHoldMessage) {
             message += ` ${CONST.DOT_SEPARATOR} ${translate('iou.hold')}`;
         }
         return message;
diff --git a/src/languages/en.ts b/src/languages/en.ts
index 96fbe463b846..02b67ef4c956 100755
--- a/src/languages/en.ts
+++ b/src/languages/en.ts
@@ -2763,7 +2763,7 @@ export default {
         categoryOutOfPolicy: 'Category no longer valid',
         conversionSurcharge: ({surcharge}: ViolationsConversionSurchargeParams) => `Applied ${surcharge}% conversion surcharge`,
         customUnitOutOfPolicy: 'Unit no longer valid',
-        duplicatedTransaction: 'Potential duplicate',
+        duplicatedTransaction: 'Duplicate',
         fieldRequired: 'Report fields are required',
         futureDate: 'Future date not allowed',
         invoiceMarkup: ({invoiceMarkup}: ViolationsInvoiceMarkupParams) => `Marked up by ${invoiceMarkup}%`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 6b81fd529233..7f17b400f075 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -3256,7 +3256,7 @@ export default {
         categoryOutOfPolicy: 'La categoría ya no es válida',
         conversionSurcharge: ({surcharge}: ViolationsConversionSurchargeParams = {}) => `${surcharge}% de recargo aplicado`,
         customUnitOutOfPolicy: 'La unidad ya no es válida',
-        duplicatedTransaction: 'Posible duplicado',
+        duplicatedTransaction: 'Duplicada',
         fieldRequired: 'Los campos del informe son obligatorios',
         futureDate: 'Fecha futura no permitida',
         invoiceMarkup: ({invoiceMarkup}: ViolationsInvoiceMarkupParams) => `Incrementado un ${invoiceMarkup}%`,

From 462b3dfdcf8910d636725d2203e5b1d339a6230c Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 26 Apr 2024 02:19:29 +0700
Subject: [PATCH 06/12] show rbr on report preview

---
 src/components/ReportActionItem/ReportPreview.tsx | 7 +++++--
 src/libs/ReportUtils.ts                           | 9 +++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/components/ReportActionItem/ReportPreview.tsx b/src/components/ReportActionItem/ReportPreview.tsx
index 5c78e1e2604e..57f15ee60e1b 100644
--- a/src/components/ReportActionItem/ReportPreview.tsx
+++ b/src/components/ReportActionItem/ReportPreview.tsx
@@ -136,8 +136,11 @@ function ReportPreview({
 
     const hasReceipts = transactionsWithReceipts.length > 0;
     const isScanning = hasReceipts && areAllRequestsBeingSmartScanned;
-    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-    const hasErrors = hasMissingSmartscanFields || (canUseViolations && ReportUtils.hasViolations(iouReportID, transactionViolations)) || ReportUtils.hasActionsWithErrors(iouReportID);
+    const hasErrors =
+        hasMissingSmartscanFields ||
+        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+        (canUseViolations && (ReportUtils.hasViolations(iouReportID, transactionViolations) || ReportUtils.hasWarnings(iouReportID, transactionViolations))) ||
+        ReportUtils.hasActionsWithErrors(iouReportID);
     const lastThreeTransactionsWithReceipts = transactionsWithReceipts.slice(-3);
     const lastThreeReceipts = lastThreeTransactionsWithReceipts.map((transaction) => ReceiptUtils.getThumbnailAndImageURIs(transaction));
 
diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
index f7dc428120a8..124e74e918d2 100644
--- a/src/libs/ReportUtils.ts
+++ b/src/libs/ReportUtils.ts
@@ -4751,6 +4751,14 @@ function hasViolations(reportID: string, transactionViolations: OnyxCollection<T
     return transactions.some((transaction) => TransactionUtils.hasViolation(transaction.transactionID, transactionViolations));
 }
 
+/**
+ * Checks to see if a report contains a violation of type `warning`
+ */
+function hasWarnings(reportID: string, transactionViolations: OnyxCollection<TransactionViolation[]>): boolean {
+    const transactions = TransactionUtils.getAllReportTransactions(reportID);
+    return transactions.some((transaction) => TransactionUtils.hasWarning(transaction.transactionID, transactionViolations));
+}
+
 /**
  * Takes several pieces of data from Onyx and evaluates if a report should be shown in the option list (either when searching
  * for reports or the reports shown in the LHN).
@@ -6304,6 +6312,7 @@ export {
     hasSmartscanError,
     hasUpdatedTotal,
     hasViolations,
+    hasWarnings,
     isActionCreator,
     isAdminRoom,
     isAdminsOnlyPostingRoom,

From 7e2d6052ca7c9b04b9911f4bb80877fa051fea11 Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 26 Apr 2024 02:26:30 +0700
Subject: [PATCH 07/12] fix crash

---
 src/components/MoneyRequestHeader.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/MoneyRequestHeader.tsx b/src/components/MoneyRequestHeader.tsx
index 8e59eba75a87..a918460e1ecb 100644
--- a/src/components/MoneyRequestHeader.tsx
+++ b/src/components/MoneyRequestHeader.tsx
@@ -75,7 +75,7 @@ function MoneyRequestHeader({
     const isApproved = ReportUtils.isReportApproved(moneyRequestReport);
     const isOnHold = TransactionUtils.isOnHold(transaction);
     const isDuplicate = TransactionUtils.isDuplicate(transaction?.transactionID ?? '');
-    const {windowWidth} = useWindowDimensions();
+    const {windowWidth, isSmallScreenWidth} = useWindowDimensions();
 
     // Only the requestor can take delete the expense, admins can only edit it.
     const isActionOwner = typeof parentReportAction?.actorAccountID === 'number' && typeof session?.accountID === 'number' && parentReportAction.actorAccountID === session?.accountID;

From e68f9f1e8732f35caab835e4f2c7a0a9afa991af Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 3 May 2024 00:04:21 +0700
Subject: [PATCH 08/12] hide unhold expense for duplicate expenses

---
 src/components/MoneyRequestHeader.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/MoneyRequestHeader.tsx b/src/components/MoneyRequestHeader.tsx
index 1274fe5a4c62..ee78ad2db4b6 100644
--- a/src/components/MoneyRequestHeader.tsx
+++ b/src/components/MoneyRequestHeader.tsx
@@ -128,7 +128,7 @@ function MoneyRequestHeader({
         const isHoldCreator = ReportUtils.isHoldCreator(transaction, report?.reportID) && isRequestIOU;
         const isTrackExpenseReport = ReportUtils.isTrackExpenseReport(report);
         const canModifyStatus = !isTrackExpenseReport && (isPolicyAdmin || isActionOwner || isApprover);
-        if (isOnHold && (isHoldCreator || (!isRequestIOU && canModifyStatus))) {
+        if (isOnHold && !isDuplicate && (isHoldCreator || (!isRequestIOU && canModifyStatus))) {
             threeDotsMenuItems.push({
                 icon: Expensicons.Stopwatch,
                 text: translate('iou.unholdExpense'),

From 3d844a0154c816c546141a660a419ae118fbcc65 Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Fri, 3 May 2024 00:08:31 +0700
Subject: [PATCH 09/12] revert unneccessary changes

---
 src/languages/es.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/languages/es.ts b/src/languages/es.ts
index 1d26803c6e79..c5a5e7f45ed7 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -730,7 +730,7 @@ export default {
         explainHold: 'Explica la razón para bloquear esta solicitud.',
         reason: 'Razón',
         holdReasonRequired: 'Se requiere una razón para bloquear.',
-        expenseOnHold: 'Este gasto quedó en suspenso. Revise los comentarios para los próximos pasos.',
+        expenseOnHold: 'Este gasto está bloqueado. Revisa los comentarios para saber como proceder.',
         expenseDuplicate: 'Esta solicitud tiene los mismos detalles que otra. Revise los duplicados para eliminar la retención.',
         reviewDuplicates: 'Revisar duplicados',
         confirmApprove: 'Confirma que quieres aprobar',

From 49473826da882a3eaeb2b989c75497881eb9d984 Mon Sep 17 00:00:00 2001
From: Joe Ph <153004152+gijoe0295@users.noreply.github.com>
Date: Sun, 5 May 2024 00:26:35 +0700
Subject: [PATCH 10/12] Update copy

Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
---
 src/languages/es.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/languages/es.ts b/src/languages/es.ts
index c5a5e7f45ed7..0c1c914896ce 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -3381,7 +3381,7 @@ export default {
         categoryOutOfPolicy: 'La categoría ya no es válida',
         conversionSurcharge: ({surcharge}: ViolationsConversionSurchargeParams = {}) => `${surcharge}% de recargo aplicado`,
         customUnitOutOfPolicy: 'La unidad ya no es válida',
-        duplicatedTransaction: 'Duplicada',
+        duplicatedTransaction: 'Duplicado',
         fieldRequired: 'Los campos del informe son obligatorios',
         futureDate: 'Fecha futura no permitida',
         invoiceMarkup: ({invoiceMarkup}: ViolationsInvoiceMarkupParams) => `Incrementado un ${invoiceMarkup}%`,

From 22b6cd9c0af4047124041478f099cbb241b7f2ea Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Sun, 5 May 2024 21:10:06 +0700
Subject: [PATCH 11/12] revert HoldBanner changes

---
 src/components/HoldBanner.tsx | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/components/HoldBanner.tsx b/src/components/HoldBanner.tsx
index de1f4debe4d0..d760d4efbe96 100644
--- a/src/components/HoldBanner.tsx
+++ b/src/components/HoldBanner.tsx
@@ -5,19 +5,14 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import Text from './Text';
 import TextPill from './TextPill';
 
-type HoldBannerProps = {
-    isRequestDuplicate?: boolean;
-    shouldShowBorderBottom?: boolean;
-};
-
-function HoldBanner({isRequestDuplicate = false, shouldShowBorderBottom = false}: HoldBannerProps) {
+function HoldBanner() {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
 
     return (
-        <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pb3, styles.ph5, shouldShowBorderBottom ? styles.borderBottom : {}]}>
+        <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pb3, styles.ph5, styles.borderBottom]}>
             <TextPill>{translate('iou.hold')}</TextPill>
-            <Text style={[styles.textLabel, styles.pl3, styles.mw100, styles.flexShrink1]}>{isRequestDuplicate ? translate('iou.expenseDuplicate') : translate('iou.expenseOnHold')}</Text>
+            <Text style={[styles.textLabel, styles.pl3, styles.mw100, styles.flexShrink1]}>{translate('iou.expenseOnHold')}</Text>
         </View>
     );
 }

From fc07750b88c794b4120290612ea0c7f4955acb13 Mon Sep 17 00:00:00 2001
From: gijoe0295 <gijoe0295@gmail.com>
Date: Thu, 16 May 2024 17:13:21 +0700
Subject: [PATCH 12/12] fix type error

---
 src/libs/TransactionUtils.ts | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/src/libs/TransactionUtils.ts b/src/libs/TransactionUtils.ts
index 47ea71577dda..cfd87ff64024 100644
--- a/src/libs/TransactionUtils.ts
+++ b/src/libs/TransactionUtils.ts
@@ -40,20 +40,6 @@ Onyx.connect({
     callback: (value) => (allReports = value),
 });
 
-let allTransactionViolations: NonNullable<OnyxCollection<TransactionViolations>> = {};
-Onyx.connect({
-    key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
-    waitForCollectionCallback: true,
-    callback: (value) => {
-        if (!value) {
-            allTransactionViolations = {};
-            return;
-        }
-
-        allTransactionViolations = value;
-    },
-});
-
 let currentUserEmail = '';
 let currentUserAccountID = -1;
 Onyx.connect({
@@ -653,7 +639,7 @@ function getRecentTransactions(transactions: Record<string, string>, size = 2):
  * @param checkDismissed - whether to check if the violation has already been dismissed as well
  */
 function isDuplicate(transactionID: string, checkDismissed = false): boolean {
-    const hasDuplicatedViolation = !!allTransactionViolations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`]?.some(
+    const hasDuplicatedViolation = !!allTransactionViolations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`]?.some(
         (violation: TransactionViolation) => violation.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION,
     );
     if (!checkDismissed) {