From 5bd8959925ca2aa7b05f2a012d094d288f5f7f87 Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Fri, 24 May 2024 16:47:31 -0700
Subject: [PATCH 1/9] fix: the logic to check if there is an accounting
 connection

---
 src/libs/PolicyUtils.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts
index 0343fa0b2c56..0eec003ba166 100644
--- a/src/libs/PolicyUtils.ts
+++ b/src/libs/PolicyUtils.ts
@@ -290,7 +290,7 @@ function extractPolicyIDFromPath(path: string) {
  * Whether the policy has active accounting integration connections
  */
 function hasAccountingConnections(policy: OnyxEntry<Policy>) {
-    return Boolean(policy?.connections);
+    return Object.keys(policy?.connections ?? {}).length !== 0;
 }
 
 function getPathWithoutPolicyID(path: string) {

From f7281db566133c9c07f1a6f7b290dd97b2922b18 Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Fri, 24 May 2024 16:54:17 -0700
Subject: [PATCH 2/9] chore: use the util function to check if there is an
 accounting connection

---
 src/pages/workspace/tags/WorkspaceTagsPage.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/workspace/tags/WorkspaceTagsPage.tsx b/src/pages/workspace/tags/WorkspaceTagsPage.tsx
index 64e9a661cd27..960056b14a96 100644
--- a/src/pages/workspace/tags/WorkspaceTagsPage.tsx
+++ b/src/pages/workspace/tags/WorkspaceTagsPage.tsx
@@ -172,7 +172,7 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) {
     const isLoading = !isOffline && policyTags === undefined;
 
     const getHeaderButtons = () => {
-        const isThereAnyAccountingConnection = Object.keys(policy?.connections ?? {}).length !== 0;
+        const isThereAnyAccountingConnection = PolicyUtils.hasAccountingConnections(policy);
 
         if (selectedTagsArray.length === 0) {
             return (

From 307a3611467b5116d87ff2ea7f8986e001a4010d Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Fri, 24 May 2024 16:54:50 -0700
Subject: [PATCH 3/9] refactor: rename a boolean variable

---
 src/pages/workspace/tags/WorkspaceTagsPage.tsx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/pages/workspace/tags/WorkspaceTagsPage.tsx b/src/pages/workspace/tags/WorkspaceTagsPage.tsx
index 960056b14a96..75bdea1629ca 100644
--- a/src/pages/workspace/tags/WorkspaceTagsPage.tsx
+++ b/src/pages/workspace/tags/WorkspaceTagsPage.tsx
@@ -172,12 +172,12 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) {
     const isLoading = !isOffline && policyTags === undefined;
 
     const getHeaderButtons = () => {
-        const isThereAnyAccountingConnection = PolicyUtils.hasAccountingConnections(policy);
+        const hasAccountingConnections = PolicyUtils.hasAccountingConnections(policy);
 
         if (selectedTagsArray.length === 0) {
             return (
                 <View style={[styles.w100, styles.flexRow, isSmallScreenWidth && styles.mb3]}>
-                    {!isThereAnyAccountingConnection && !isMultiLevelTags && (
+                    {!hasAccountingConnections && !isMultiLevelTags && (
                         <Button
                             medium
                             success
@@ -202,7 +202,7 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) {
 
         const options: Array<DropdownOption<DeepValueOf<typeof CONST.POLICY.TAGS_BULK_ACTION_TYPES>>> = [];
 
-        if (!isThereAnyAccountingConnection && !isMultiLevelTags) {
+        if (!hasAccountingConnections && !isMultiLevelTags) {
             options.push({
                 icon: Expensicons.Trashcan,
                 text: translate(selectedTagsArray.length === 1 ? 'workspace.tags.deleteTag' : 'workspace.tags.deleteTags'),

From 92cb58fb0a85021e7790f5e2031881ff241240c1 Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Fri, 24 May 2024 18:33:40 -0700
Subject: [PATCH 4/9] fix: hide "Delete rate" button when there is an
 accounting connection

---
 src/pages/workspace/taxes/WorkspaceTaxesPage.tsx | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
index 21be6d1db419..f98d86699e20 100644
--- a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
+++ b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
@@ -52,6 +52,7 @@ function WorkspaceTaxesPage({
     const defaultExternalID = policy?.taxRates?.defaultExternalID;
     const foreignTaxDefault = policy?.taxRates?.foreignTaxDefault;
     const isFocused = useIsFocused();
+    const hasAccountingConnections = PolicyUtils.hasAccountingConnections(policy);
 
     const fetchTaxes = useCallback(() => {
         openPolicyTaxesPage(policyID);
@@ -172,14 +173,16 @@ function WorkspaceTaxesPage({
 
     const dropdownMenuOptions = useMemo(() => {
         const isMultiple = selectedTaxesIDs.length > 1;
-        const options: Array<DropdownOption<WorkspaceTaxRatesBulkActionType>> = [
-            {
+        const options: Array<DropdownOption<WorkspaceTaxRatesBulkActionType>> = [];
+
+        if (!hasAccountingConnections) {
+            options.push({
                 icon: Expensicons.Trashcan,
                 text: isMultiple ? translate('workspace.taxes.actions.deleteMultiple') : translate('workspace.taxes.actions.delete'),
                 value: CONST.POLICY.TAX_RATES_BULK_ACTION_TYPES.DELETE,
                 onSelected: () => setIsDeleteModalVisible(true),
-            },
-        ];
+            });
+        }
 
         // `Disable rates` when at least one enabled rate is selected.
         if (selectedTaxesIDs.some((taxID) => !policy?.taxRates?.taxes[taxID]?.isDisabled)) {
@@ -201,7 +204,7 @@ function WorkspaceTaxesPage({
             });
         }
         return options;
-    }, [policy?.taxRates?.taxes, selectedTaxesIDs, toggleTaxes, translate]);
+    }, [hasAccountingConnections, policy?.taxRates?.taxes, selectedTaxesIDs, toggleTaxes, translate]);
 
     const headerButtons = !selectedTaxesIDs.length ? (
         <View style={[styles.w100, styles.flexRow, isSmallScreenWidth && styles.mb3]}>

From 455d50a0b2884fcce312af26007cf3f3894d9d06 Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Wed, 29 May 2024 17:31:35 -0700
Subject: [PATCH 5/9] chore: use an existing function to check if the object is
 empty or not

---
 src/libs/PolicyUtils.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts
index 707342c073ba..61d9a356cce9 100644
--- a/src/libs/PolicyUtils.ts
+++ b/src/libs/PolicyUtils.ts
@@ -302,7 +302,7 @@ function extractPolicyIDFromPath(path: string) {
  * Whether the policy has active accounting integration connections
  */
 function hasAccountingConnections(policy: OnyxEntry<Policy>) {
-    return Object.keys(policy?.connections ?? {}).length !== 0;
+    return isEmptyObject(policy?.connections);
 }
 
 function getPathWithoutPolicyID(path: string) {

From 7418175b9d28acec89f4f91d5dfda57ee60a9877 Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Wed, 29 May 2024 17:52:29 -0700
Subject: [PATCH 6/9] fix: the boolean logic

---
 src/libs/PolicyUtils.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts
index 61d9a356cce9..780e14562376 100644
--- a/src/libs/PolicyUtils.ts
+++ b/src/libs/PolicyUtils.ts
@@ -302,7 +302,7 @@ function extractPolicyIDFromPath(path: string) {
  * Whether the policy has active accounting integration connections
  */
 function hasAccountingConnections(policy: OnyxEntry<Policy>) {
-    return isEmptyObject(policy?.connections);
+    return !isEmptyObject(policy?.connections);
 }
 
 function getPathWithoutPolicyID(path: string) {

From a2290046fd7cf72098a7f1098d09c5383fc83955 Mon Sep 17 00:00:00 2001
From: Hayata Suenaga <hayata@expensify.com>
Date: Wed, 29 May 2024 18:00:00 -0700
Subject: [PATCH 7/9] fix: hide add rate button

---
 .../workspace/taxes/WorkspaceTaxesPage.tsx    | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
index f339d543acc2..02312e5d4404 100644
--- a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
+++ b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
@@ -207,14 +207,17 @@ function WorkspaceTaxesPage({
 
     const headerButtons = !selectedTaxesIDs.length ? (
         <View style={[styles.w100, styles.flexRow, styles.gap2, isSmallScreenWidth && styles.mb3]}>
-            <Button
-                medium
-                success
-                onPress={() => Navigation.navigate(ROUTES.WORKSPACE_TAX_CREATE.getRoute(policyID))}
-                icon={Expensicons.Plus}
-                text={translate('workspace.taxes.addRate')}
-                style={[isSmallScreenWidth && styles.flex1]}
-            />
+            {!hasAccountingConnections && (
+                <Button
+                    medium
+                    success
+                    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_TAX_CREATE.getRoute(policyID))}
+                    icon={Expensicons.Plus}
+                    text={translate('workspace.taxes.addRate')}
+                    style={[isSmallScreenWidth && styles.flex1]}
+                />
+            )}
+
             <Button
                 medium
                 onPress={() => Navigation.navigate(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID))}

From 456003ded1dc7169cad3426950e00b48e70ee067 Mon Sep 17 00:00:00 2001
From: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
Date: Thu, 30 May 2024 23:29:31 +0100
Subject: [PATCH 8/9] disable tax deletion if connected to accounting

---
 .../workspace/taxes/WorkspaceEditTaxPage.tsx  | 22 +++++++++++--------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx b/src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx
index 8ccff7b4e126..f6ac9b892cd9 100644
--- a/src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx
+++ b/src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx
@@ -40,6 +40,7 @@ function WorkspaceEditTaxPage({
     const {windowWidth} = useWindowDimensions();
     const [isDeleteModalVisible, setIsDeleteModalVisible] = useState(false);
     const canEdit = policy && PolicyUtils.canEditTaxRate(policy, taxID);
+    const hasAccountingConnections = PolicyUtils.hasAccountingConnections(policy);
 
     const toggleTaxRate = () => {
         if (!currentTaxRate) {
@@ -58,14 +59,17 @@ function WorkspaceEditTaxPage({
     };
 
     const threeDotsMenuItems: ThreeDotsMenuItem[] = useMemo(
-        () => [
-            {
-                icon: Expensicons.Trashcan,
-                text: translate('common.delete'),
-                onSelected: () => setIsDeleteModalVisible(true),
-            },
-        ],
-        [translate],
+        () =>
+            canEdit && !hasAccountingConnections
+                ? [
+                      {
+                          icon: Expensicons.Trashcan,
+                          text: translate('common.delete'),
+                          onSelected: () => setIsDeleteModalVisible(true),
+                      },
+                  ]
+                : [],
+        [translate, canEdit, hasAccountingConnections],
     );
 
     if (!currentTaxRate) {
@@ -86,7 +90,7 @@ function WorkspaceEditTaxPage({
                     <HeaderWithBackButton
                         title={currentTaxRate?.name}
                         threeDotsMenuItems={threeDotsMenuItems}
-                        shouldShowThreeDotsButton={!!canEdit}
+                        shouldShowThreeDotsButton={threeDotsMenuItems.length > 0}
                         threeDotsAnchorPosition={styles.threeDotsPopoverOffsetNoCloseButton(windowWidth)}
                     />
                     <OfflineWithFeedback

From 69ae5cfdb27ad0b9a8016b8d730e2cdee158c2ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucien=20Akchot=C3=A9?= <lucien@expensify.com>
Date: Fri, 31 May 2024 13:23:31 +0200
Subject: [PATCH 9/9] fix prettier

---
 src/pages/workspace/taxes/WorkspaceTaxesPage.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
index 059793bf4e16..608dfe2b26c8 100644
--- a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
+++ b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
@@ -208,7 +208,7 @@ function WorkspaceTaxesPage({
             });
         }
         return options;
-     }, [hasAccountingConnections, policy?.taxRates?.taxes, selectedTaxesIDs, toggleTaxes, translate]);
+    }, [hasAccountingConnections, policy?.taxRates?.taxes, selectedTaxesIDs, toggleTaxes, translate]);
 
     const headerButtons = !selectedTaxesIDs.length ? (
         <View style={[styles.w100, styles.flexRow, isSmallScreenWidth && styles.mb3]}>