Make MediaPipeController tracking local to model #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59.
Removes the use of
global_transform
inMediaPipeController
for tracking purposes. This made it impossible to position theModelController
in any way without also affecting the tracking by tilting the model, and making the hand offset static to a certain location in-world.Some changes to note:
head_vertical_offset
any longer (I set the default to0.0
) if we just make it relative to the default resting head pose.Notable issues that I can remember that might need to be addressed:
top_level
to display correctly, thus do not move with the model.camera_origin_offset
could be replaced with a calibration method.