Magic fields bug.

[Anastaciaa]

Normally magic fields working fine but if you shoot for example soul fire rune before, it stops working and if you stay on the field it spamming fire damge.
I'm not sure if this issue is only mine or othire.

[Olddies710]

this is a problem of othire i'm olddies from otland and that bug reproduce to me too

[babymannen]

So how is it supposed to work? Not like this obviously, but should the most recent added condition (fire) always override the previous?

For example:
Shot by soul fire then step in fire field = condition from soulfire overriden and condition from fire field applied?

[Ochmar]

@babymannen It should deal 10 damage on step in.
No overriding.
Soulfire > fire field

[Ochmar]

This is due to condition "DELAYED" in soulfire.
I don't know how DELAYED + magic fields should work in general, so I'm not pushing pull request.

[Anastaciaa]

This happen also with monster for example if poison spider poison you.

[pasturryx]

.

[Wirless]

void MagicField::onStepInField(Creature* creature)
{
if(!creature)
return;

if(isUnstepable() || isBlocking(creature))
{
	if(!creature->isGhost())
		g_game.internalRemoveItem(creature, this, 1);

	return;
}

if(!creature->isAttackable())
	return;

const ItemType& it = items[id];
if(!it.condition)
	return;

uint32_t ownerId = getOwner();
Tile* tile = getTile();

Condition* condition = it.condition->clone();
if(ownerId && !tile->hasFlag(TILESTATE_HARDCOREZONE))
{
	if(Creature* owner = g_game.getCreatureByID(ownerId))
	{
		Player* ownerPlayer = owner->getPlayer();
		if(!ownerPlayer && owner->isPlayerSummon())
			ownerPlayer = owner->getPlayerMaster();

		bool harmful = true;
		if((g_game.getWorldType() == WORLDTYPE_OPTIONAL || tile->hasFlag(TILESTATE_OPTIONALZONE)) && ownerPlayer)
			harmful = false;
		else if(Player* player = creature->getPlayer())
		{
			if(ownerPlayer && Combat::isProtected(ownerPlayer, player))
				harmful = false;
		}

		if(!harmful || (OTSYS_TIME() - createTime) <= (uint32_t)g_config.getNumber(
			ConfigManager::FIELD_OWNERSHIP) || creature->hasBeenAttacked(ownerId))
			condition->setParam(CONDITIONPARAM_OWNER, ownerId);
	}
}

creature->addCondition(condition);

}

[Wirless]

purposeful function is actually depracated i had to remove it and something else within my code to make fields work properly.

[pasturryx]

Anyone has found the way to solve this issue?

[Wirless]

remove purposeful

[Wirless]

void MagicField::onStepInField(Creature* creature, bool purposeful/= true/)
to
void MagicField::onStepInField(Creature* creature)

[Wirless]

and if(ownerId != 0 && purposeful){

if(ownerId != 0){

[pasturryx]

its working without flaws, u tested it man?
@Wirless you could make a PR

[waqmaz93]

its also in tfs 1.4 like that. does someone know how should it work?