Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertion error message #6

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Improve assertion error message #6

merged 1 commit into from
Jun 9, 2020

Conversation

bjoluc
Copy link
Contributor

@bjoluc bjoluc commented May 18, 2020

Sorry for this silly PR 😄 I just found the error message "assert failed to validation error(s)" a little confusing. I think "assert failed due to validation error(s)" is a bit clearer.

@tuukkamustonen
Copy link
Contributor

Indeed. Or it could even be just "assert failed due to:". Anyway, this is already better, thanks! :)

(Sorry for the late reply, I have no idea why Github doesn't send me email notifications of this repository. I get notified for all the repositories I'm watching, but the one where I'm actually maintainer doesn't get notified. Crazy. Randomly happened to notice your PR.)

@tuukkamustonen
Copy link
Contributor

Seems like Tarvis builds are not being triggered, I need to check that...

@tuukkamustonen
Copy link
Contributor

I think there were some auth issues after a long period of inactivity. Travis had actually triggered, but would not report status back.

Could you rebase? I want to be sure it works for other users, too, and not just me :|

@bjoluc
Copy link
Contributor Author

bjoluc commented Jun 9, 2020

Crazy. Randomly happened to notice your PR

Glad you discovered it anyway! 🎉

Could you rebase? I want to be sure it works for other users, too, and not just me :|

Sure thing!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.194% when pulling 415872a on bjoluc:improve-assertion-error into 9632451 on F-Secure:master.

@tuukkamustonen tuukkamustonen merged commit 2a00ff9 into WithSecureOpenSource:master Jun 9, 2020
@bjoluc bjoluc deleted the improve-assertion-error branch June 9, 2020 13:58
@tuukkamustonen
Copy link
Contributor

Seems like it worked this time 👍

@bjoluc
Copy link
Contributor Author

bjoluc commented Jun 9, 2020

Thanks a lot!

@tuukkamustonen
Copy link
Contributor

tuukkamustonen commented Jun 9, 2020

Released this (and couple of internal boilerplate adjustments) in 1.2.0 🌷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants