Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat jumps when you send a message #3154

Open
Garanas opened this issue Mar 24, 2024 · 4 comments
Open

Chat jumps when you send a message #3154

Garanas opened this issue Mar 24, 2024 · 4 comments
Labels

Comments

@Garanas
Copy link
Member

Garanas commented Mar 24, 2024

Describe the bug

Chat jumps when a message is send by the user.

To Reproduce

Wait until there's need for a scrollbar and then send a message.

Expected behavior

It to not jump.

downlord-chat-jump-01.mp4
@Garanas Garanas added the bug label Mar 24, 2024
@Ivan-Shaml
Copy link

Ivan-Shaml commented Aug 25, 2024

Hi,

Doesn't this change (ChatMessageViewController:348 in commit) happen to fix the issue? I also couldn't reproduce it with the latest version (2024.8.0).

@Sheikah45
Copy link
Member

Unfortunately in my experience it still happens for some users sometimes

@sulikdan
Copy link
Contributor

sulikdan commented Sep 21, 2024

Could someone describe this in better detail? I see multiple scenarios and I feel, if im gonna fix one, another will fall apart.
Situations(assuming that chat is full of messages and scrollbar is visible):

  • An user moved scrollbar somewhere, e.g. top of chat. Suddenly, someone writes a message -> what should happen? Is this the scenario we are talking of?
  • An user focus is at the end of chat. Suddenly, someone writes a message -> again, what? Should it now follow new messages or the last message, where focus at?

Ad2: Do we assuming same results, when a message is send either from other users or the client user?

I'm wondering, if the fix should also introduce button like the intellij has for logs (scroll to end)

@Sheikah45
Copy link
Member

Sheikah45 commented Sep 21, 2024

It is supposed to work like discord chat. When a user is already at the bottom of the chat it should scroll up to include the most recent message when a new message is received. When a user is not at the bottom of the chat it should not scroll and should preserve their location in the chat window.

When the user themself sends a message it scrolls to the bottom no matter where they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants