Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization key to notice messages #1000

Open
Askaholic opened this issue Jan 8, 2024 · 0 comments
Open

Add localization key to notice messages #1000

Askaholic opened this issue Jan 8, 2024 · 0 comments

Comments

@Askaholic
Copy link
Collaborator

Askaholic commented Jan 8, 2024

Notice messages should also include a localization key so that the client can translate the messages into the correct language. This key should be optional and the client should always be able to fall back to the English text field if it receives a notice message with no localization key.

{
    "command": "notice",
    "style": "info",
    "text": "This is some text",
    "i18n_key": "some.text.key"
}

It probably doesn't make sense to add these keys to the notice messages generated by a ClientError as those messages aren't 'supposed to' ever make it to a correctly implemented client. (In practice the protocol isn't quite at the point where that is possible so maybe we want to add this in the future, but lets just start with non ClientErrors for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant