Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of modified Base Classes and AppDefs #240

Open
lukaspie opened this issue Jun 17, 2024 · 1 comment
Open

List of modified Base Classes and AppDefs #240

lukaspie opened this issue Jun 17, 2024 · 1 comment
Assignees
@sanbrock

Comments

@lukaspie
Copy link
Collaborator

lukaspie commented Jun 17, 2024 •
edited
Loading

  • NXwaveplate
  • NXopt_window
  • NXlens_opt
  • NXbeam
@lukaspie lukaspie changed the title List of modified Base Classes List of modified Base Classes and AppDefs Jun 17, 2024
@lukaspie
Copy link
Collaborator Author

lukaspie commented Jun 17, 2024 •
edited
Loading

@sanbrock I just made a mock PR from FAIRmat-NFDI:nexus_definitions:fairmat to nexusformat/definitions:main to check which base class and appdef NXDL files where changed:

  • NXdata
  • NXaperture
  • NXsource
  • NXdetector (unclear)
  • NXenvironment -> added NXactuator
  • NXinstrument -> added NXactuator
  • NXprocess
  • NXroot
  • NXsample
  • NXsample_component
  • NXsensor
  • NXtransformations
  • NXuser -> added NXidentifier

For some of these, the NXDL file has changed quite a bit, but this may just be due to different indentation, formatting, etc., so we should check carefully if the contents have also changed.

@sanbrock sanbrock self-assigned this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanbrock sanbrock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanbrock @lukaspie