Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and further quality improvement on nexus/nxdl_utils code #302

Open
mkuehbach opened this issue Mar 28, 2024 · 0 comments
Open

Comments

@mkuehbach
Copy link
Collaborator

mkuehbach commented Mar 28, 2024

Currently pynxtools via core nexus utility functions within nexus.py make use of nxdl_utils.py from nexus_definitions. There are aspects of these two set of library functionalities that are worth a refactoring:

  • [ ] Refactor the current use of a mixture of etree and lxml to use lxml throughout
  • [ ] Refactor to assure that type checking of function argument and return values in called and calling functions

See related issue FAIRmat-NFDI/nexus_definitions#206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant