bgpd: compare aigp after local route check in bgp_path_info_cmp() #17199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Oct 23, 2024
|
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
Sure, will do. Thanks. |
ton31337
approved these changes
Oct 24, 2024
The topotest verifies that a local route is favored irrespective of its AIGP value. Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
For consistency between RIB and BGP, the aigp comparison should be made after the local route check in bgp bestpath selection. Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
enkechen-panw
force-pushed
the
aigp-fix5
branch
from
f736878
to
6a7049a
Compare
|
The failed topotest is just not reliable, and is not related to the patch. Here is the failure rate from the weekly report: I ran it locally with and without the patch, and the results were also inconsistent. |
This was referenced Oct 25, 2024
ton31337
added a commit
that referenced
this pull request
Oct 25, 2024
bgpd: compare aigp after local route check in bgp_path_info_cmp() (backport #17199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency between RIB and BGP, the aigp comparison should be made after the local route check in bgp bestpath selection.
As a reference, that's exactly what Cisco IOS does:
https://www.cisco.com/c/en/us/support/docs/ip/border-gateway-protocol-bgp/119001-configure-aigp-00.html