Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: compare aigp after local route check in bgp_path_info_cmp() #17199

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

enkechen-panw
Copy link
Contributor

@enkechen-panw enkechen-panw commented Oct 22, 2024

For consistency between RIB and BGP, the aigp comparison should be made after the local route check in bgp bestpath selection.

As a reference, that's exactly what Cisco IOS does:

https://www.cisco.com/c/en/us/support/docs/ip/border-gateway-protocol-bgp/119001-configure-aigp-00.html

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but IMO we should have a topotest verifying this, agree?

@ton31337
Copy link
Member

@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

@ton31337 ton31337 added this to the 10.2 milestone Oct 23, 2024
Copy link

mergify bot commented Oct 23, 2024

backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

@enkechen-panw
Copy link
Contributor Author

LGTM, but IMO we should have a topotest verifying this, agree?

Sure, will do. Thanks.

@frrbot frrbot bot added the tests Topotests, make check, etc label Oct 23, 2024
@github-actions github-actions bot added size/L and removed size/M labels Oct 23, 2024
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but frrbot styling should be fixed before merging.

The topotest verifies that a local route is favored irrespective
of its AIGP value.

Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
For consistency between RIB and BGP, the aigp comparison should
be made after the local route check in bgp bestpath selection.

Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
@enkechen-panw
Copy link
Contributor Author

enkechen-panw commented Oct 25, 2024

The failed topotest is just not reliable, and is not related to the patch. Here is the failure rate from the weekly report:

 zebra_fec_nexthop_resolution (31, 29, 2,  6.45%)

I ran it locally with and without the patch, and the results were also inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants