ospfd: ospfd core if hello packet exceeds link MTU #3657

nitinsoniism · 2019-01-24T08:58:47Z

Ospfd cored because of an assert when we try to write more than the MTU
size to the ospf packet buffer stream. The problem is - we allocate only MTU
sized buffer. The expectation is that Hello packets are never large
enough to approach MTU.

Ticket: CM-22380
Signed-off-by: Nitin Soni nsoni@cumulusnetworks.com
Reviewed-by: CCR-8204

Summary

[While forming hello packet, ospfd loops through neighbors and fills in the information in the stream. If there are more than 365 neighbors, hello packet size goes beyond MTU. We allocate only MTU sized buffer. While calling stream_put_ipv4() in ospf_make_hello(), we abort() leading to a crash. Instead of crashing, this fix discards hello and logs an error. One should not have so many neighbors behind an interface.

Core dump backtrace -

Program terminated with signal SIGABRT, Aborted.
#0 0x00007f73d2c30067 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#0 0x00007f73d2c30067 in raise () from /lib/x86_64-linux-gnu/libc.so.6
No symbol table info available.
#1 0x00007f73d2c31448 in abort () from /lib/x86_64-linux-gnu/libc.so.6
No symbol table info available.
#2 0x00007f73d417d896 in _zlog_assert_failed (assertion=assertion@entry=0x7f73d41c1f12 "0", file=file@entry=0x7f73d41c17b9 "lib/stream.c", line=line@entry=814, function=function@entry=0x7f73d41c1b80 <func.12224> "stream_put_ipv4") at lib/log.c:713
No locals.
#3 0x00007f73d41991dc in stream_put_ipv4 (s=s@entry=0xd458acbfa0, l=1828782278) at lib/stream.c:814
func = "stream_put_ipv4"
#4 0x000000d456235b9c in ospf_make_hello (s=0xd458acbfa0, oi=0xd456fea670) at ospfd/ospf_packet.c:3321
rn = 0xd458ab8f80
length =
mask = {s_addr = 65535}
flag = 0
nbr =
p = 40
#5 ospf_hello_send_sub (oi=0xd456fea670, addr=83886304) at ospfd/ospf_packet.c:3589
op = 0xd458acbbe0
length = 24
PRETTY_FUNCTION = "ospf_hello_send_sub"
#6 0x000000d456227d00 in ospf_hello_timer (thread=) at ospfd/ospf_ism.c:257
oi = 0xd456fea670
#7 0x00007f73d419f380 in thread_call (thread=thread@entry=0x7ffc58a12bf0) at lib/thread.c:1552
realtime =
cputime = 0
before = {cpu = {ru_utime = {tv_sec = 0, tv_usec = 34000}, ru_stime = {tv_sec = 0, tv_usec = 240000}, {ru_maxrss = 35228, __ru_maxrss_word = 35228}, {ru_ixrss = 0, __ru_ixrss_word = 0}, {ru_idrss = 0, __ru_idrss_word = 0}, {ru_isrss = 0, __ru_isrss_word = 0}, {ru_minflt = 16539, __ru_minflt_word = 16539}, {ru_majflt = 0, __ru_majflt_word = 0}, {ru_nswap = 0, __ru_nswap_word = 0}, {ru_inblock = 0, __ru_inblock_word = 0}, {ru_oublock = 0, __ru_oublock_word = 0}, {ru_msgsnd = 0, __ru_msgsnd_word = 0}, {ru_msgrcv = 0, __ru_msgrcv_word = 0}, {ru_nsignals = 0, __ru_nsignals_word = 0}, {ru_nvcsw = 396, __ru_nvcsw_word = 396}, {ru_nivcsw = 9, __ru_nivcsw_word = 9}}, real = {tv_sec = 247470, tv_usec = 640268}}
after = {cpu = {ru_utime = {tv_sec = 911988307000, tv_usec = 34000}, ru_stime = {tv_sec = 640255, tv_usec = 911988307200}, {ru_maxrss = 0, __ru_maxrss_word = 0}, {ru_ixrss = 0, __ru_ixrss_word = 0}, {ru_idrss = 0, __ru_idrss_word = 0}, {ru_isrss = 2, __ru_isrss_word = 2}, {ru_minflt = 247470, __ru_minflt_word = 247470}, {ru_majflt = 640255150, __ru_majflt_word = 640255150}, {ru_nswap = 1, __ru_nswap_word = 1}, {ru_inblock = 0, __ru_inblock_word = 0}, {ru_oublock = 0, __ru_oublock_word = 0}, {ru_msgsnd = 0, __ru_msgsnd_word = 0}, {ru_msgrcv = 0, __ru_msgrcv_word = 0}, {ru_nsignals = 0, __ru_nsignals_word = 0}, {ru_nvcsw = 395, __ru_nvcsw_word = 395}, {ru_nivcsw = 9, __ru_nivcsw_word = 9}}, real = {tv_sec = 247470, tv_usec = 7357964613805746176}}
#8 0x00007f73d417adc8 in frr_run (master=0xd456bd3400) at lib/libfrr.c:920
instanceinfo = '\000' <repeats 63 times>
func = "frr_run"
thread = {type = 4 '\004', add_type = 2 '\002', next = 0x0, prev = 0x0, ref = 0xd456fea718, master = 0xd456bd3400, func = 0xd456227cd0 <ospf_hello_timer>, arg = 0xd456fea670, u = {val = 247470, fd = 247470, sands = {tv_sec = 247470, tv_usec = 640255}}, index = 0, real = {tv_sec = 247470, tv_usec = 640268}, hist = 0xd456ffe890, yield = 10000, funcname = 0xd45627bddf "(ospf_hello_timer)", schedfrom = 0xd45627bdf2 "ospfd/ospf_ism.c", schedfrom_line = 260, mtx = {__data = {__lock = 0, __count = 0, __owner = 0, __nusers = 0, __kind = 0, __spins = 0, __elision = 0, __list = {__prev = 0x0, __next = 0x0}}, __size = '\000' <repeats 39 times>, __align = 0}}
#9 0x000000d456220753 in main (argc=, argv=0x7ffc58a12e18) at ospfd/ospf_main.c:225
instance = 0
]

Related Issue

[fill here if applicable]

Components

[ospfd]

NetDEF-CI · 2019-01-24T09:26:21Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

NetBSD 7 amd64 build: Successful
Ubuntu 16.04 amd64 build: Successful
Ubuntu 16.04 i386 build: Successful
Ubuntu 18.04 amd64 build: Successful
CentOS 6 amd64 build: Successful
NetBSD 6 amd64 build: Successful
CentOS 7 amd64 build: Successful
Debian 8 amd64 build: Successful
Debian 9 amd64 build: Successful
Ubuntu 12.04 amd64 build: Successful
FreeBSD 10 amd64 build: Successful
Ubuntu 14.04 amd64 build: Successful
OpenBSD 6 amd64 build: Successful
Fedora 24 amd64 build: Successful
FreeBSD 11 amd64 build: Successful

OmniOS amd64 build: Failed

Make failed for OmniOS amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI010BUILD/ErrorLog/log_make.txt)

checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether gcc supports -diag-error 10006... no
checking whether gcc supports -std=gnu11... yes
checking whether gcc -std=gnu11 supports -g... yes
checking whether gcc -std=gnu11 supports -Os... yes
checking whether gcc -std=gnu11 supports -fno-omit-frame-pointer... yes
checking whether gcc -std=gnu11 supports -funwind-tables... yes
checking whether gcc -std=gnu11 supports -Wall... yes

OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI010BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings:

OmniOS amd64 build: Failed

Make failed for OmniOS amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI010BUILD/ErrorLog/log_make.txt)

checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether gcc supports -diag-error 10006... no
checking whether gcc supports -std=gnu11... yes
checking whether gcc -std=gnu11 supports -g... yes
checking whether gcc -std=gnu11 supports -Os... yes
checking whether gcc -std=gnu11 supports -fno-omit-frame-pointer... yes
checking whether gcc -std=gnu11 supports -funwind-tables... yes
checking whether gcc -std=gnu11 supports -Wall... yes

OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI010BUILD/config.status/config.status

Report for ospf_errors.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #175: FILE: /tmp/f1-24664/ospf_errors.c:175:
< WARNING: line over 80 characters
< #176: FILE: /tmp/f1-24664/ospf_errors.c:176:
Report for ospf_packet.c | 14 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #3314: FILE: /tmp/f1-24664/ospf_packet.c:3314:
< WARNING: line over 80 characters
< #3315: FILE: /tmp/f1-24664/ospf_packet.c:3315:
< WARNING: Too many leading tabs - consider code refactoring
< #3315: FILE: /tmp/f1-24664/ospf_packet.c:3315:
< ERROR: Please, no nonstandard integer types in new code.
< #3315: FILE: /tmp/f1-24664/ospf_packet.c:3315:
< WARNING: line over 80 characters
< #3319: FILE: /tmp/f1-24664/ospf_packet.c:3319:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_make_hello', this function's name, in a string
< #3320: FILE: /tmp/f1-24664/ospf_packet.c:3320:
< WARNING: quoted string split across lines
< #3321: FILE: /tmp/f1-24664/ospf_packet.c:3321:

Warnings Generated during build:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6472/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

NetDEF-CI · 2019-01-24T11:23:19Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for ospf_errors.c | 8 issues
===============================================
< WARNING: Avoid line continuations in quoted strings
< #175: FILE: /tmp/f1-9913/ospf_errors.c:175:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-9913/ospf_errors.c:177:
< WARNING: Avoid line continuations in quoted strings
< #177: FILE: /tmp/f1-9913/ospf_errors.c:177:
< WARNING: line over 80 characters
< #178: FILE: /tmp/f1-9913/ospf_errors.c:178:
Report for ospf_packet.c | 10 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-9913/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3317: FILE: /tmp/f1-9913/ospf_packet.c:3317:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_make_hello', this function's name, in a string
< #3318: FILE: /tmp/f1-9913/ospf_packet.c:3318:
< WARNING: quoted string split across lines
< #3319: FILE: /tmp/f1-9913/ospf_packet.c:3319:
< WARNING: line over 80 characters
< #3326: FILE: /tmp/f1-9913/ospf_packet.c:3326:

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA 262d4dd

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6475/artifact/shared/static_analysis/index.html

LabN-CI · 2019-01-24T12:08:19Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3657 `022bbe0`
Date	01/24/2019
Start	06:44:27
Finish	07:08:09
Run-Time	23:42
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-24-06:44:27.txt
Log	autoscript-2019-01-24-06:45:09.log.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-01-24T14:37:32Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6480/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

CentOS 6 amd64 build: Successful
Debian 9 amd64 build: Successful
Ubuntu 12.04 amd64 build: Successful
OmniOS amd64 build: Successful
Ubuntu 16.04 i386 build: Successful
NetBSD 6 amd64 build: Successful
CentOS 7 amd64 build: Successful
Debian 8 amd64 build: Successful
FreeBSD 10 amd64 build: Successful
Ubuntu 14.04 amd64 build: Successful
OpenBSD 6 amd64 build: Successful
NetBSD 7 amd64 build: Successful
Fedora 24 amd64 build: Successful
FreeBSD 11 amd64 build: Successful
Ubuntu 18.04 amd64 build: Successful

Ubuntu 16.04 amd64 build: Failed

Ubuntu 16.04 amd64 build: No useful log found

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Ubuntu 16.04 amd64 build: Failed

Ubuntu 16.04 amd64 build: No useful log found

Report for ospf_errors.c | 8 issues
===============================================
< WARNING: Avoid line continuations in quoted strings
< #175: FILE: /tmp/f1-16750/ospf_errors.c:175:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-16750/ospf_errors.c:177:
< WARNING: Avoid line continuations in quoted strings
< #177: FILE: /tmp/f1-16750/ospf_errors.c:177:
< WARNING: line over 80 characters
< #178: FILE: /tmp/f1-16750/ospf_errors.c:178:
Report for ospf_packet.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-16750/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-16750/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3315: FILE: /tmp/f1-16750/ospf_packet.c:3315:
< WARNING: quoted string split across lines
< #3317: FILE: /tmp/f1-16750/ospf_packet.c:3317:
< WARNING: line over 80 characters
< #3324: FILE: /tmp/f1-16750/ospf_packet.c:3324:

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6480/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6480/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6480/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6480/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6480/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

odd22

Patch is OK for me once CI/CD error solved

NetDEF-CI · 2019-01-24T14:59:57Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Topotest tests on Ubuntu 16.04 i386: Successful
Fedora 24 rpm pkg check: Successful
CentOS 7 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Debian 9 deb pkg check: Successful
CentOS 6 rpm pkg check: Successful
Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-6478/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-01-24 06:19:43,638 ERROR: ******************************************************************************
2019-01-24 06:19:43,639 ERROR: Test Target Summary                                                  Pass Fail
2019-01-24 06:19:43,639 ERROR: ******************************************************************************
2019-01-24 06:19:43,639 ERROR: FILE: scripts/adjacencies.py
2019-01-24 06:19:43,639 ERROR: 9    r4     PE->P2 (loopback) ping +0.00 secs                        0    1
2019-01-24 06:19:43,639 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/output.log for details of errors
2019-01-24 06:19:43,642 ERROR: assert failed at "bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/test_adjacencies": 1 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-6478/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
*** defaultIntf: warning: lm has no interfaces
2019-01-24 14:33:43,844 ERROR: 'check_labels' failed after 181.21 seconds
2019-01-24 14:33:43,846 ERROR: assert failed at "test_lm-proxy-topo1/test_lm_proxy": wrong labels
assert False

pe1: ldpd crashed. Core file found - Backtrace follows:
[New LWP 4536]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/ldpd -n 2'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f868f506801 in __GI_abort () at abort.c:79
#2  0x00007f868fd4298d in core_handler (signo=7, siginfo=0x7fff28045c70, context=<optimized out>) at lib/sigevent.c:249
#3  <signal handler called>
#4  0x00007f868f8c916e in __libc_wait (stat_loc=0x7fff280460e4) at ../sysdeps/unix/sysv/linux/wait.c:29
#5  0x000055fcf2c732f8 in ldpd_shutdown () at ldpd/ldpd.c:435
#6  0x000055fcf2c738c7 in sigint () at ldpd/ldpd.c:150
#7  0x00007f868fd42a28 in quagga_sigevent_process () at lib/sigevent.c:105
#8  0x00007f868fd4f265 in thread_fetch (m=m@entry=0x55fcf3eee290, fetch=fetch@entry=0x7fff28046270) at lib/thread.c:1425
#9  0x00007f868fd237e3 in frr_run (master=0x55fcf3eee290) at lib/libfrr.c:1010
#10 0x000055fcf2c7031f in main (argc=<optimized out>, argv=<optimized out>) at ldpd/ldpd.c:405
2019-01-24 14:33:47,812 ERROR: assert failed at "test_lm-proxy-topo1/test_lm_proxy": 
pe1: ldpd crashed. Core file found - Backtrace follows:
[New LWP 4536]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/ldpd -n 2'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f868f506801 in __GI_abort () at abort.c:79
#2  0x00007f868fd4298d in core_handler (signo=7, siginfo=0x7fff28045c70, context=<optimized out>) at lib/sigevent.c:249
#3  <signal handler called>
#4  0x00007f868f8c916e in __libc_wait (stat_loc=0x7fff280460e4) at ../sysdeps/unix/sysv/linux/wait.c:29
#5  0x000055fcf2c732f8 in ldpd_shutdown () at ldpd/ldpd.c:435
#6  0x000055fcf2c738c7 in sigint () at ldpd/ldpd.c:150
#7  0x00007f868fd42a28 in quagga_sigevent_process () at lib/sigevent.c:105
#8  0x00007f868fd4f265 in thread_fetch (m=m@entry=0x55fcf3eee290, fetch=fetch@entry=0x7fff28046270) at lib/thread.c:1425
#9  0x00007f868fd237e3 in frr_run (master=0x55fcf3eee290) at lib/libfrr.c:1010
#10 0x000055fcf2c7031f in main (argc=<optimized out>, argv=<optimized out>) at ldpd/ldpd.c:405

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-6478/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-01-24 06:19:43,638 ERROR: ******************************************************************************
2019-01-24 06:19:43,639 ERROR: Test Target Summary                                                  Pass Fail
2019-01-24 06:19:43,639 ERROR: ******************************************************************************
2019-01-24 06:19:43,639 ERROR: FILE: scripts/adjacencies.py
2019-01-24 06:19:43,639 ERROR: 9    r4     PE->P2 (loopback) ping +0.00 secs                        0    1
2019-01-24 06:19:43,639 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/output.log for details of errors
2019-01-24 06:19:43,642 ERROR: assert failed at "bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/test_adjacencies": 1 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-6478/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
*** defaultIntf: warning: lm has no interfaces
2019-01-24 14:33:43,844 ERROR: 'check_labels' failed after 181.21 seconds
2019-01-24 14:33:43,846 ERROR: assert failed at "test_lm-proxy-topo1/test_lm_proxy": wrong labels
assert False

pe1: ldpd crashed. Core file found - Backtrace follows:
[New LWP 4536]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/ldpd -n 2'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f868f506801 in __GI_abort () at abort.c:79
#2  0x00007f868fd4298d in core_handler (signo=7, siginfo=0x7fff28045c70, context=<optimized out>) at lib/sigevent.c:249
#3  <signal handler called>
#4  0x00007f868f8c916e in __libc_wait (stat_loc=0x7fff280460e4) at ../sysdeps/unix/sysv/linux/wait.c:29
#5  0x000055fcf2c732f8 in ldpd_shutdown () at ldpd/ldpd.c:435
#6  0x000055fcf2c738c7 in sigint () at ldpd/ldpd.c:150
#7  0x00007f868fd42a28 in quagga_sigevent_process () at lib/sigevent.c:105
#8  0x00007f868fd4f265 in thread_fetch (m=m@entry=0x55fcf3eee290, fetch=fetch@entry=0x7fff28046270) at lib/thread.c:1425
#9  0x00007f868fd237e3 in frr_run (master=0x55fcf3eee290) at lib/libfrr.c:1010
#10 0x000055fcf2c7031f in main (argc=<optimized out>, argv=<optimized out>) at ldpd/ldpd.c:405
2019-01-24 14:33:47,812 ERROR: assert failed at "test_lm-proxy-topo1/test_lm_proxy": 
pe1: ldpd crashed. Core file found - Backtrace follows:
[New LWP 4536]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/ldpd -n 2'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f868f506801 in __GI_abort () at abort.c:79
#2  0x00007f868fd4298d in core_handler (signo=7, siginfo=0x7fff28045c70, context=<optimized out>) at lib/sigevent.c:249
#3  <signal handler called>
#4  0x00007f868f8c916e in __libc_wait (stat_loc=0x7fff280460e4) at ../sysdeps/unix/sysv/linux/wait.c:29
#5  0x000055fcf2c732f8 in ldpd_shutdown () at ldpd/ldpd.c:435
#6  0x000055fcf2c738c7 in sigint () at ldpd/ldpd.c:150
#7  0x00007f868fd42a28 in quagga_sigevent_process () at lib/sigevent.c:105
#8  0x00007f868fd4f265 in thread_fetch (m=m@entry=0x55fcf3eee290, fetch=fetch@entry=0x7fff28046270) at lib/thread.c:1425
#9  0x00007f868fd237e3 in frr_run (master=0x55fcf3eee290) at lib/libfrr.c:1010
#10 0x000055fcf2c7031f in main (argc=<optimized out>, argv=<optimized out>) at ldpd/ldpd.c:405

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for ospf_errors.c | 8 issues
===============================================
< WARNING: Avoid line continuations in quoted strings
< #175: FILE: /tmp/f1-3920/ospf_errors.c:175:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-3920/ospf_errors.c:177:
< WARNING: Avoid line continuations in quoted strings
< #177: FILE: /tmp/f1-3920/ospf_errors.c:177:
< WARNING: line over 80 characters
< #178: FILE: /tmp/f1-3920/ospf_errors.c:178:
Report for ospf_packet.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-3920/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-3920/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3315: FILE: /tmp/f1-3920/ospf_packet.c:3315:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_make_hello', this function's name, in a string
< #3316: FILE: /tmp/f1-3920/ospf_packet.c:3316:
< WARNING: quoted string split across lines
< #3317: FILE: /tmp/f1-3920/ospf_packet.c:3317:
< WARNING: line over 80 characters
< #3324: FILE: /tmp/f1-3920/ospf_packet.c:3324:

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA a28436c

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/shared/static_analysis/index.html

NetDEF-CI · 2019-01-24T15:04:21Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for ospf_errors.c | 8 issues
===============================================
< WARNING: Avoid line continuations in quoted strings
< #175: FILE: /tmp/f1-10208/ospf_errors.c:175:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-10208/ospf_errors.c:177:
< WARNING: Avoid line continuations in quoted strings
< #177: FILE: /tmp/f1-10208/ospf_errors.c:177:
< WARNING: line over 80 characters
< #178: FILE: /tmp/f1-10208/ospf_errors.c:178:
Report for ospf_packet.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-10208/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-10208/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3315: FILE: /tmp/f1-10208/ospf_packet.c:3315:
< WARNING: quoted string split across lines
< #3317: FILE: /tmp/f1-10208/ospf_packet.c:3317:
< WARNING: line over 80 characters
< #3324: FILE: /tmp/f1-10208/ospf_packet.c:3324:

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA a28436c

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6479/artifact/shared/static_analysis/index.html

LabN-CI · 2019-01-24T15:17:03Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3657 `6802d55`
Date	01/24/2019
Start	09:53:14
Finish	10:16:53
Run-Time	23:39
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-24-09:53:14.txt
Log	autoscript-2019-01-24-09:53:55.log.bz2
Memory

For details, please contact louberger

LabN-CI · 2019-01-24T16:14:18Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3657 `c8d807b`
Date	01/24/2019
Start	10:50:27
Finish	11:14:08
Run-Time	23:41
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-24-10:50:27.txt
Log	autoscript-2019-01-24-10:51:09.log.bz2
Memory

For details, please contact louberger

LabN-CI · 2019-01-24T16:44:09Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3657 `9b14232`
Date	01/24/2019
Start	11:20:21
Finish	11:43:59
Run-Time	23:38
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-24-11:20:21.txt
Log	autoscript-2019-01-24-11:21:02.log.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-01-24T16:56:20Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for ospf_errors.c | 12 issues
===============================================
< WARNING: quoted string split across lines
< #176: FILE: /tmp/f1-3030/ospf_errors.c:176:
< WARNING: break quoted strings at a space character
< #176: FILE: /tmp/f1-3030/ospf_errors.c:176:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-3030/ospf_errors.c:177:
< WARNING: quoted string split across lines
< #178: FILE: /tmp/f1-3030/ospf_errors.c:178:
< WARNING: quoted string split across lines
< #179: FILE: /tmp/f1-3030/ospf_errors.c:179:
< WARNING: break quoted strings at a space character
< #179: FILE: /tmp/f1-3030/ospf_errors.c:179:
Report for ospf_packet.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-3030/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-3030/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3315: FILE: /tmp/f1-3030/ospf_packet.c:3315:
< WARNING: quoted string split across lines
< #3317: FILE: /tmp/f1-3030/ospf_packet.c:3317:
< WARNING: line over 80 characters
< #3324: FILE: /tmp/f1-3030/ospf_packet.c:3324:

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA c8d3e79

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6481/artifact/shared/static_analysis/index.html

NetDEF-CI · 2019-01-24T16:57:17Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for ospf_errors.c | 12 issues
===============================================
< WARNING: quoted string split across lines
< #176: FILE: /tmp/f1-11918/ospf_errors.c:176:
< WARNING: break quoted strings at a space character
< #176: FILE: /tmp/f1-11918/ospf_errors.c:176:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-11918/ospf_errors.c:177:
< WARNING: quoted string split across lines
< #178: FILE: /tmp/f1-11918/ospf_errors.c:178:
< WARNING: quoted string split across lines
< #179: FILE: /tmp/f1-11918/ospf_errors.c:179:
< WARNING: break quoted strings at a space character
< #179: FILE: /tmp/f1-11918/ospf_errors.c:179:
Report for ospf_packet.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-11918/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-11918/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3314: FILE: /tmp/f1-11918/ospf_packet.c:3314:
< WARNING: line over 80 characters
< #3316: FILE: /tmp/f1-11918/ospf_packet.c:3316:
< WARNING: quoted string split across lines
< #3318: FILE: /tmp/f1-11918/ospf_packet.c:3318:
< WARNING: line over 80 characters
< #3325: FILE: /tmp/f1-11918/ospf_packet.c:3325:

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA c8d3e79

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6482/artifact/shared/static_analysis/index.html

Jafaral · 2019-01-25T22:53:48Z

@nitinsoniism Can you please fix the remaining build warnings?

nitinsoniism · 2019-01-26T03:22:55Z

@Jafaral, unfortunately, we can't do much about some of these warnings. It is throwing a warning if I break the string across multiple lines and it is considering that as going beyond 80 chars even though it is split across lines. Or maybe I didn't understand the warnings properly.

LabN-CI · 2019-01-26T03:44:11Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3657 `02aea13`
Date	01/25/2019
Start	22:20:20
Finish	22:44:00
Run-Time	23:40
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-25-22:20:20.txt
Log	autoscript-2019-01-25-22:21:02.log.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-01-26T04:26:01Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Fedora 24 rpm pkg check: Successful
Topology tests on Ubuntu 16.04 amd64: Successful
Debian 9 deb pkg check: Successful
Topotest tests on Ubuntu 16.04 i386: Successful
CentOS 7 rpm pkg check: Successful
Static analyzer (clang): Successful
Ubuntu 12.04 deb pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful
Topology tests on Ubuntu 18.04 amd64: Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful

IPv4 ldp protocol on Ubuntu 16.04: Failed

Warnings Generated during build:

Checkout code: Successful with additional warnings:

IPv4 ldp protocol on Ubuntu 16.04: Failed

Report for ospf_errors.c | 8 issues
===============================================
< WARNING: quoted string split across lines
< #176: FILE: /tmp/f1-13339/ospf_errors.c:176:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-13339/ospf_errors.c:177:
< WARNING: quoted string split across lines
< #178: FILE: /tmp/f1-13339/ospf_errors.c:178:
< WARNING: quoted string split across lines
< #179: FILE: /tmp/f1-13339/ospf_errors.c:179:
Report for ospf_packet.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-13339/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-13339/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3314: FILE: /tmp/f1-13339/ospf_packet.c:3314:
< WARNING: line over 80 characters
< #3316: FILE: /tmp/f1-13339/ospf_packet.c:3316:
< WARNING: quoted string split across lines
< #3318: FILE: /tmp/f1-13339/ospf_packet.c:3318:
< WARNING: line over 80 characters
< #3325: FILE: /tmp/f1-13339/ospf_packet.c:3325:

Warnings Generated during build:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA d57e451

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6504/artifact/shared/static_analysis/index.html

Ospfd cored because of an assert when we try to write more than the MTU size to the ospf packet buffer stream. The problem is - we allocate only MTU sized buffer. The expectation is that Hello packets are never large enough to approach MTU. Instead of crashing, this fix discards hello and logs an error. One should not have so many neighbors behind an interface. Ticket: CM-22380 Signed-off-by: Nitin Soni <nsoni@cumulusnetworks.com> Reviewed-by: CCR-8204

LabN-CI · 2019-01-28T04:54:11Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3657 `9b18d58`
Date	01/27/2019
Start	23:30:22
Finish	23:54:01
Run-Time	23:39
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-27-23:30:22.txt
Log	autoscript-2019-01-27-23:31:04.log.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-01-28T05:38:01Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for ospf_errors.c | 8 issues
===============================================
< WARNING: quoted string split across lines
< #176: FILE: /tmp/f1-16301/ospf_errors.c:176:
< WARNING: line over 80 characters
< #177: FILE: /tmp/f1-16301/ospf_errors.c:177:
< WARNING: quoted string split across lines
< #178: FILE: /tmp/f1-16301/ospf_errors.c:178:
< WARNING: quoted string split across lines
< #179: FILE: /tmp/f1-16301/ospf_errors.c:179:
Report for ospf_packet.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #3313: FILE: /tmp/f1-16301/ospf_packet.c:3313:
< WARNING: Too many leading tabs - consider code refactoring
< #3313: FILE: /tmp/f1-16301/ospf_packet.c:3313:
< WARNING: line over 80 characters
< #3314: FILE: /tmp/f1-16301/ospf_packet.c:3314:
< WARNING: line over 80 characters
< #3316: FILE: /tmp/f1-16301/ospf_packet.c:3316:
< WARNING: quoted string split across lines
< #3318: FILE: /tmp/f1-16301/ospf_packet.c:3318:
< WARNING: line over 80 characters
< #3325: FILE: /tmp/f1-16301/ospf_packet.c:3325:

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

CLANG Static Analyzer Summary

Github Pull Request 3657, comparing to Git base SHA d57e451

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6508/artifact/shared/static_analysis/index.html

nitinsoniism force-pushed the ospf_mtu_crash branch from b3d7f91 to 022bbe0 Compare January 24, 2019 10:14

nitinsoniism force-pushed the ospf_mtu_crash branch 3 times, most recently from 33f615c to 6802d55 Compare January 24, 2019 13:57

odd22 approved these changes Jan 24, 2019

View reviewed changes

nitinsoniism force-pushed the ospf_mtu_crash branch 2 times, most recently from c8d807b to 9b14232 Compare January 24, 2019 15:55

nitinsoniism force-pushed the ospf_mtu_crash branch from 9b14232 to 02aea13 Compare January 26, 2019 03:19

nitinsoniism force-pushed the ospf_mtu_crash branch from 02aea13 to 9b18d58 Compare January 28, 2019 04:28

riw777 approved these changes Jan 29, 2019

View reviewed changes

riw777 merged commit 3bce693 into FRRouting:master Jan 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ospfd: ospfd core if hello packet exceeds link MTU #3657

ospfd: ospfd core if hello packet exceeds link MTU #3657

nitinsoniism commented Jan 24, 2019

NetDEF-CI commented Jan 24, 2019

NetDEF-CI commented Jan 24, 2019

LabN-CI commented Jan 24, 2019

NetDEF-CI commented Jan 24, 2019

odd22 left a comment

NetDEF-CI commented Jan 24, 2019

NetDEF-CI commented Jan 24, 2019

LabN-CI commented Jan 24, 2019

LabN-CI commented Jan 24, 2019

LabN-CI commented Jan 24, 2019

NetDEF-CI commented Jan 24, 2019

NetDEF-CI commented Jan 24, 2019

Jafaral commented Jan 25, 2019

nitinsoniism commented Jan 26, 2019

LabN-CI commented Jan 26, 2019

NetDEF-CI commented Jan 26, 2019

LabN-CI commented Jan 28, 2019

NetDEF-CI commented Jan 28, 2019

ospfd: ospfd core if hello packet exceeds link MTU #3657

ospfd: ospfd core if hello packet exceeds link MTU #3657

Conversation

nitinsoniism commented Jan 24, 2019

Summary

Related Issue

Components

NetDEF-CI commented Jan 24, 2019

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

OmniOS amd64 build: Failed

Warnings Generated during build:

Checkout code: Successful with additional warnings:

OmniOS amd64 build: Failed

Warnings Generated during build:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

Debian 9 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

NetDEF-CI commented Jan 24, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian 9 amd64 build: Successful with additional warnings:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

LabN-CI commented Jan 24, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jan 24, 2019

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Ubuntu 16.04 amd64 build: Failed

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

odd22 left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Jan 24, 2019

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 18.04 amd64: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1604/MemoryLeaks/ Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 18.04 amd64: Failed

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

NetDEF-CI commented Jan 24, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6478/artifact/TOPOU1804/MemoryLeaks/