Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👤mommy now refers to the user using $USER var~ #131

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

Bikoil
Copy link
Contributor

@Bikoil Bikoil commented Sep 3, 2024

Heya! So I made the program use for the MOMMY_SWEETIE variable instead of just "girl" to use the $USER variable

This is a very small addition that I thought would fit pretty good, so it's more universal

Also, I was gonna open this pull request in your dev branch, but It doesn't seem to exist, So I had to open it in main

@FWDekker
Copy link
Owner

FWDekker commented Sep 3, 2024

cool! good idea, actually.

a few requests:

  1. could you replace $USER by $LOGNAME? surprisingly, $USER is not POSIX, so if we use $USER some shells might get an empty string instead.
  2. in fact, replace $USER by ${LOGNAME:-girl}, so that, if $LOGNAME is unset or empty (somehow), the default becomes girl. (if you have a better suggestion for girl, let me know!)
  3. could you add this to the README.md? in the section configuration, in the list of all settings, the default value of MOMMY_SWEETIE should be set to "<username>".

as for the dev branch thing: thanks for noticing that! that's from an old workflow, i'll make sure to remove that from the contributing.md :-)

@FWDekker FWDekker self-assigned this Sep 3, 2024
@FWDekker FWDekker added the enhancement Improvement of existing feature label Sep 3, 2024
@Bikoil
Copy link
Contributor Author

Bikoil commented Sep 3, 2024

cool! good idea, actually.

a few requests:

  1. could you replace $USER by $LOGNAME? surprisingly, $USER is not POSIX, so if we use $USER some shells might get an empty string instead.
  2. in fact, replace $USER by ${LOGNAME:-girl}, so that, if $LOGNAME is unset or empty (somehow), the default becomes girl. (if you have a better suggestion for girl, let me know!)
  3. could you add this to the README.md? in the section configuration, in the list of all settings, the default value of MOMMY_SWEETIE should be set to "<username>".

as for the dev branch thing: thanks for noticing that! that's from an old workflow, i'll make sure to remove that from the contributing.md :-)

No problem at all! I'll set those up instantly when I can, Thanks

@Bikoil
Copy link
Contributor Author

Bikoil commented Sep 3, 2024

@FWDekker Alright changes have been made, you can tell me if you want to change anything in it or if you want to merge it or not :D

Also I have no idea what the hell happened to the README.md even though I did like 1 change into it

@FWDekker
Copy link
Owner

FWDekker commented Sep 4, 2024

thanks for the changes!

euhm, yeah, looks like your editor quite aggressively adds/removes whitespace. unfortunately, some of that whitespace is actually important for the layout. i've undone those changes now :-)

i'll merge the changes after all ci returns positive! :) thank you!

edit: ok, some tests fail, probably because they expect the word girl in the output but now it's a username. don't worry, i'll fix it!

@FWDekker
Copy link
Owner

FWDekker commented Sep 4, 2024

i had to rebase your changes to fix and test something in a separate branch first, but it all works now! :)

@FWDekker FWDekker merged commit b3b94ee into FWDekker:main Sep 4, 2024
9 checks passed
@Bikoil
Copy link
Contributor Author

Bikoil commented Sep 4, 2024

ty! :D

@Bikoil Bikoil deleted the dev branch September 5, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants