Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers' font size update with respective line's greatest font size #148

Closed
JordanMartinez opened this issue Jun 8, 2015 · 1 comment

Comments

@JordanMartinez
Copy link
Contributor

Hello Tomas,

I noticed that, if I changed my area's style's font size by using the remapping approach (#142), the LineNumberFactory doesn't update its labels' font size as well. Thus, you get an area like the one shown below:
hello_018

Ideally, all of the respective line's styles' font sizes should be compared until the largest one is found. The largest font size should be the size of its respective line number label. Is such an enhancement outside the scope of this project?

I made a variation of the LineNumberFactory that will update its label sizes when a Property changes (the same Property that remaps my style to the new font size), but is there a better way around this?

@JordanMartinez
Copy link
Contributor Author

After thinking about this more, isn't the line number support specifically for code editors? What would be a situation where the above enhancement would be necessary? If an area had a few lines, each of which having a different largest font size, the result would look strange.

However, in a code editor, changing the font size might be desirable. Unlike above, every line's text (no matter the style) would most likely have the same font size, so each label used to display the line number would also have the same font size. Thus, updating the font size of a code editor should also update the font size for the line number.

Fortunately, this can already be the case (#149) aside from the empty line's font size not changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant