Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ParagraphText's background and underline shapes #484

Closed
JordanMartinez opened this issue Apr 7, 2017 · 1 comment
Closed

Optimize ParagraphText's background and underline shapes #484

JordanMartinez opened this issue Apr 7, 2017 · 1 comment
Labels
enhancement performance

Comments

@JordanMartinez
Copy link
Contributor

Coming from Tomas' comment in 411, optimize ParagraphText to only instantiate its backgroundShape and underlineShape objects when needed.
@JordanMartinez JordanMartinez mentioned this issue May 3, 2017
Closed
@JordanMartinez JordanMartinez mentioned this issue Aug 1, 2017
Merged
@JordanMartinez
Copy link
Contributor Author

This was more properly closed by #558. The shapes were further optimized by only using one shape per shared value between multiple consecutive TextExt nodes rather than one per segment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JordanMartinez