-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baking reverb in hammer causes the game to crash. #368
Comments
This is important imo. Having reverb changes the sound dynamic in an important way. I have no idea why this is broken. |
I have stopped it from crashing but you'll have to test it to see if the data is actually used because I have no idea. You can try adding more entries to scripts/surfaceproperties_steamaudio.txt, if alyx has that file, it's possible you could use that. |
I've enabled everything I can see to allow reverb but I'm unable to hear any difference, let me know if you can make a map with it working. |
Ill have a go, thanks layla.
|
I managed to get it to work, reverb node needs to be in the vmix, I'm not sure yet how to do this properly though because it needs to be disabled when the map has no baked reverb otherwise there will be silence. |
Interesting, I didn't know vmix was actually used for anything currently. |
Well I tried the reverb calc in my map and it works nicely, only problem is that surfaces havent been set up to reverb correctly so everything is kind of muffled. |
Yeah I don't know if I'm just using it incorrectly in the vmix or you just have to tweak the surfaces. You can do snd_steamaudio_reverb_simtype 0 to enable dynamic reverb and change surfaceproperties_steamaudio.txt and reload the map to try out different values |
So this is fixed but it will be decided if we even keep steam audio reverb, I think it's shit |
I think it's worth keeping and seeing if there's any way to improve its implementation here. This video does a pretty good job of showing how good it can sound if it's got a decent implementation, particularly the HRTF/3D audio and occlusion behind walls. |
I remember in HL:A you need to do "Generate Probes" before baking reverb. Maybe that's why it sounds somewhat muffled? |
This is something that will have to be discussed. Might be worth closing this issue as it doesn't crash anymore and start a discussion instead. |
It's started crashing again for some reason. I could still close it though if more audio work needs to be done first. |
Describe the bug
When baking reverb on a map in hammer, the game will crash. I've tried setting the parameters to different values but it always closes with no error messages.
To Reproduce
Expected behavior
Reverb is baked and the map can be played with sounds echoing in rooms.
The text was updated successfully, but these errors were encountered: