Skip to content

Commit

Permalink
Increase verbose level for common operations (#613)
Browse files Browse the repository at this point in the history
This addresses the issue described in #564, and increases the verbose
level for common operation logs to `2` (which is the default log level).
This allows to significantly reduce the noise of the logs by setting the
log level to `1`, without turning off logs completely or affecting default
functionality.
  • Loading branch information
lauraseidler committed Jun 27, 2023
1 parent b708f9c commit ccda8aa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func createController(kubeClient kubernetes.Interface, informer cache.SharedInde
evt.EventType = "create"
evt.ResourceType = resource
evt.Namespace = objectMeta(obj).Namespace
klog.Infof("%s/%s has been added.", resource, evt.Key)
klog.V(2).Infof("%s/%s has been added.", resource, evt.Key)
wq.Add(evt)
},
DeleteFunc: func(obj interface{}) {
Expand All @@ -195,7 +195,7 @@ func createController(kubeClient kubernetes.Interface, informer cache.SharedInde
evt.EventType = "delete"
evt.ResourceType = resource
evt.Namespace = objectMeta(obj).Namespace
klog.Infof("%s/%s has been deleted.", resource, evt.Key)
klog.V(2).Infof("%s/%s has been deleted.", resource, evt.Key)
wq.Add(evt)
},
UpdateFunc: func(old interface{}, new interface{}) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/vpa/vpa.go
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ func (r Reconciler) updateVPA(vpa vpav1.VerticalPodAutoscaler) error {
klog.Errorf("Error updating VPA/%s in Namespace/%s: %v", vpa.Name, vpa.Namespace, retryErr)
return retryErr
}
klog.Infof("Updated VPA/%s in Namespace/%s", vpa.Name, vpa.Namespace)
klog.V(2).Infof("Updated VPA/%s in Namespace/%s", vpa.Name, vpa.Namespace)
} else {
klog.Infof("Not updating VPA/%s in Namespace/%s due to dryrun.", vpa.Name, vpa.Namespace)
}
Expand Down

0 comments on commit ccda8aa

Please sign in to comment.