Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAllTopControllers generate too much load on api server #689

Closed
2 tasks done
max0ne opened this issue Jan 18, 2024 · 0 comments
Closed
2 tasks done

getAllTopControllers generate too much load on api server #689

max0ne opened this issue Jan 18, 2024 · 0 comments
Labels
bug Something isn't working stale Marked as stale by stalebot triage This bug needs triage

Comments

@max0ne
Copy link

max0ne commented Jan 18, 2024

What happened?

When Goldilocks performs reconcile on each namespace, over any pod change, it performs a list on all pods of that namespace, this generates a significant amount of load on apiserver. If a deployment rollout happens where all old pods are removed and replaced with new pods, this generates O(n^2) amount of load on apiserver, with n being number of pods.

This amount of load is not acceptable in larger size clusters, we've seen similar problems with using vector vectordotdev/vector#16798 and it brought down our apiserver

This problem is also mentioned in this issue but not fully addressed:
#536

What did you expect to happen?

A potential solution:
Goldilocks can only list apps/v1/deployments and some other known top controller types, this list can be specified through config

How can we reproduce this?

N/A

Version

any version after 4.0.0

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@max0ne max0ne added bug Something isn't working triage This bug needs triage labels Jan 18, 2024
@github-actions github-actions bot added the stale Marked as stale by stalebot label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
Development

No branches or pull requests

1 participant