Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources: limits/requests should be ignored for initContainers #125

Closed
alexcurtin opened this issue May 22, 2019 · 2 comments
Closed

Resources: limits/requests should be ignored for initContainers #125

alexcurtin opened this issue May 22, 2019 · 2 comments

Comments

@alexcurtin
Copy link

Currently, polaris reports a warning of cpu/memory limits and requests missing on initContainers but per https://kubernetes.io/docs/concepts/workloads/pods/init-containers/#resources I don't think that setting limits/requests on initContainers is standard / best practice?

Correct me if wrong!
@robscott robscott mentioned this issue May 23, 2019
Merged
@robscott
Copy link
Contributor

Hey @alexcurtin, this is a great find, thanks! Although these can be useful in some cases, I think those are quite rare, so we're disabling these checks for init containers by default. I've opened a PR for that referenced above, we should get this out in our next release.

@rbren
Copy link
Contributor

rbren commented Jun 5, 2019

Fixed in 0.1.5. Thanks for the report!

@rbren rbren closed this as completed Jun 5, 2019
@sudermanjr sudermanjr mentioned this issue Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robscott @rbren @alexcurtin