Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polaris config should selectively override values instead of replacing entire config #910

Closed
2 tasks done
JoeHCQ1 opened this issue Feb 2, 2023 · 8 comments · Fixed by #1075
Closed
2 tasks done
Labels
enhancement Adding additional functionality or improvements

Comments

@JoeHCQ1
Copy link
Contributor

JoeHCQ1 commented Feb 2, 2023

What happened?

I created a config file as instructed in ./docs/customization/checks.md. Here is my config file:

checks:
  pullPolicyNotAlways: ignore

When I re-ran my scan, I dropped from 71 problems to 0.

Before:
image

After:
image

Looks like my list of checks replaced the typical list of checks instead of overriding one specific value.

What did you expect to happen?

I expected to only make the pullPolicyNotAlways warning go away, not erase all existing checks.

How can we reproduce this?

Given a helm chart with a lot of warnings and dangers (of varied types), put my config above in a file and point the CLI tool at it with -c polaris_config.yaml and watch it go to zero errors.

Version

7.3.0 + my change in #909

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@JoeHCQ1 JoeHCQ1 added bug Something isn't working triage This bug needs triage labels Feb 2, 2023
@DaveOuds
Copy link

DaveOuds commented Mar 6, 2023

Is there a default config we can use in the mean time? The examples/config-full.yaml don't seem up to date.

For instance the topologySpreadConstraint is missing.

@rbren
Copy link
Contributor

rbren commented May 4, 2023

Agreed this is a pretty big limitation currently--the config is all-or-nothing.

You can use examples/config.yaml--that's our default config.

@rbren rbren added enhancement Adding additional functionality or improvements and removed bug Something isn't working triage This bug needs triage labels May 4, 2023
@rbren rbren changed the title polaris config file replaces typical config instead of selectively overriding values polaris config should selectively override values instead of replacing entire config May 4, 2023
@Flauschbaellchen
Copy link

This issue requests the same feature as described in #770 wich was automatically closed as being stale by the github bot

@michalschott
Copy link

This would be really huge enhancement 🙏

@callmegar
Copy link

+1 on the enhancement, also docs should mention the all or nothing functionality, had to dig a little while.

@github-actions github-actions bot added the stale Marked as stale by stalebot label Aug 22, 2023
@Flauschbaellchen
Copy link

Flauschbaellchen commented Aug 31, 2023

@rbren Same as #770 , this issue has now been closed as being stale but it was not yet resolved.
can you please reopen at least one of them again to keep track of this feature request?
It is still a big limitation that a manual config overrides the default one completely.

@devantler
Copy link

Was this ever resolved? If not, is it something you could consider in the near future? 🙏 It would be awesome not having to overwrite all defaults, when just wanting to add to them, or change a few.

@vitorvezani
Copy link
Member

vitorvezani commented Oct 9, 2024

I've created an initial implementation PR to address this feature - #1075

@vitorvezani vitorvezani reopened this Oct 9, 2024
@github-actions github-actions bot removed the stale Marked as stale by stalebot label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants