-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polaris config should selectively override values instead of replacing entire config #910
Comments
Is there a default config we can use in the mean time? The For instance the |
Agreed this is a pretty big limitation currently--the config is all-or-nothing. You can use |
This issue requests the same feature as described in #770 wich was automatically closed as being stale by the github bot |
This would be really huge enhancement 🙏 |
+1 on the enhancement, also docs should mention the all or nothing functionality, had to dig a little while. |
Was this ever resolved? If not, is it something you could consider in the near future? 🙏 It would be awesome not having to overwrite all defaults, when just wanting to add to them, or change a few. |
I've created an initial implementation PR to address this feature - #1075 |
What happened?
I created a config file as instructed in ./docs/customization/checks.md. Here is my config file:
When I re-ran my scan, I dropped from 71 problems to 0.
Before:
After:
Looks like my list of checks replaced the typical list of checks instead of overriding one specific value.
What did you expect to happen?
I expected to only make the
pullPolicyNotAlways
warning go away, not erase all existing checks.How can we reproduce this?
Given a helm chart with a lot of warnings and dangers (of varied types), put my config above in a file and point the CLI tool at it with
-c polaris_config.yaml
and watch it go to zero errors.Version
7.3.0 + my change in #909
Search
Code of Conduct
Additional context
No response
The text was updated successfully, but these errors were encountered: