Modifying Commit Author

[creativecreatorormaybenot]

I think this action is really useful 🙌 And you certainly saved the time of many others as well :)

Description

It would be great if one could specify the commit author configuration for the PR.

Existing example

The "Deploy to GitHub Pages" action allows you to do that for example: https://github.com/marketplace/actions/deploy-to-github-pages

See https://github.com/marketplace/actions/deploy-to-github-pages#optional-choices.

[github-actions]

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

[FantasticFiasco]

Hi @creativecreatorormaybenot!

Glad you think you saved some time using this action 😄

It is the parameters GIT_CONFIG_NAME and GIT_CONFIG_EMAIL you are thinking of, which currently in this action is hardcoded to github-actions and github-actions@github.com?

[creativecreatorormaybenot]

@FantasticFiasco Yes, exactly. It would be amazing to sign the commits of course, however, I assume that this would be too complicated.

If you look at the commit in my repo (creativecreatorormaybenot/funvas@039e652), it looks pretty ugly because of two things: 1. it has @github-actions as the PR author (which is okay), however, it has a user without an icon as the commit author. That should likely have my config instead (i.e. my name and email) 👍

[FantasticFiasco]

I think we can support git name and e-mail without any breaking changes, and I don't foresee any problems with the implementation either.

Regarding GPG signing, please open a new issue regarding that and we'll see what we can do about it. I think I need your input there, because it would most probably require you to save your private key in GitHub, and I would argue that not everybody would be comfortable doing so.

[creativecreatorormaybenot]

@FantasticFiasco I agree - I probably do not even want to open an issue because of that.

[FantasticFiasco]

@creativecreatorormaybenot, would you be able to update your configuration, and replace <your name> and <your e-mail> with relevant values.

- uses: FantasticFiasco/action-update-license-year@66564cc720675678f03c008d254ebbf5f22609ac
      with:
        token: ${{ secrets.GITHUB_TOKEN }}
        path: '**/LICENSE'
        commitTitle: Update copyright year in LICENSE file(s)
        prTitle: Update copyright year in LICENSE file(s)
        prBody: New Year is here and we want to keep up with time :)
        assignees: creativecreatorormaybenot
        commitAuthorName: <your name>
        commitAuthorEmail: <your e-mail>

If you find that the behavior meets your expectations, I'll continue with releasing this officially.

[creativecreatorormaybenot]

@FantasticFiasco will do tomorrow - thanks!

[creativecreatorormaybenot]

@FantasticFiasco Worked great! Thank you so much ❤

See creativecreatorormaybenot/wakelock#83 :)

[FantasticFiasco]

You should be able to use @v2 of the action now, since the feature officially has been released.

Thanks for your feature suggestion!