Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Some misaligned text in localization (for example russian) #41

Closed
CfYz-R opened this issue Nov 21, 2023 · 4 comments
Closed

Some misaligned text in localization (for example russian) #41

CfYz-R opened this issue Nov 21, 2023 · 4 comments

Comments

@CfYz-R
Copy link

CfYz-R commented Nov 21, 2023

image

image

Modifying language files doesn't work...

@CfYz-R
Copy link
Author

CfYz-R commented Nov 21, 2023

About window has the same issue even in default English language...

@yulian5
Copy link

yulian5 commented Dec 19, 2023

The problem here is that the width for all Dialogs I checked is hard-coded.

I made a fix for 2 mentioned dialogs
231218.NetBox.patch
and then I found that all dialogs should be fixed so I stopped here.

I think the best approach will be to pass the width from TFarText to parent like TFarDialog and calculate minimum width already inside parent dialog. So I think it's will be fine to apply provided patch for mentioned 2 dialogs and then I proceed with more improvements for all other dialogs.

I tested fixes with all 3 languages for NetBox, looks fine. For "About" dialog there is an extra space on the right side, not clear where it come from. I checked a few dialogs from Far Manager, some of then also have that extra space on the right.

Alex,

I didn't provide any changelog changes or version changes. Please, let me know, If I need to.

I see that NetBox actually needs a lot of work.

@yulian5
Copy link

yulian5 commented Dec 28, 2023

Do I need to create a pull request instead of posting a patch?

@alabuzhev
Copy link
Collaborator

Moved to michaellukashov#395

@alabuzhev alabuzhev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants