Modified for flatlist (from #629) #705

xcarpentier · 2018-01-15T17:21:28Z

codecov · 2018-01-15T17:26:02Z

Codecov Report

Merging #705 into master will decrease coverage by 0.69%.
The diff coverage is 23.33%.

@@            Coverage Diff            @@
##           master     #705     +/-   ##
=========================================
- Coverage   43.17%   42.47%   -0.7%     
=========================================
  Files          20       20             
  Lines         498      485     -13     
  Branches      104      106      +2     
=========================================
- Hits          215      206      -9     
+ Misses        216      210      -6     
- Partials       67       69      +2

Impacted Files	Coverage Δ
src/Bubble.js	`46.15% <ø> (ø)`	⬆️
src/Send.js	`71.42% <ø> (ø)`	⬆️
src/Composer.js	`30.76% <ø> (ø)`	⬆️
src/Day.js	`85.71% <ø> (ø)`	⬆️
src/InputToolbar.js	`63.33% <0%> (-4.53%)`	⬇️
src/Avatar.js	`81.25% <100%> (ø)`	⬆️
src/utils.js	`87.5% <100%> (+45.83%)`	⬆️
src/Message.js	`60.71% <100%> (ø)`	⬆️
src/MessageContainer.js	`25.64% <14.28%> (-13.25%)`	⬇️
src/MessageText.js	`43.33% <50%> (-1.5%)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbf812...b55d841. Read the comment docs.

xcarpentier · 2018-01-16T15:27:30Z

I think we need to have an expo publish on every PR to test easely...

cooperka · 2018-01-16T15:47:26Z

Thanks for cleaning this up @xcarpentier 🍻 But fyi I probably won't have time to review this week, you may want to find someone else to review.

brunocascio · 2018-01-16T17:45:39Z

Great work @xcarpentier !

I am in vacation now, but I saw part of the code. Is there a way to remove internal state and use only props in order to make this lib completely stateless? What do you think?

brunolemos · 2018-01-17T13:13:01Z

src/MessageContainer.js

-        {...invertibleScrollViewProps}
-        ref={(component) => (this._invertibleScrollViewRef = component)}
-      />
+      <View style={{ transform: [{ scaleY: -1 }, { perspective: 1280 }] }}>


brunolemos · 2018-01-17T13:17:12Z

src/MessageContainer.js

          enableEmptySections
          automaticallyAdjustContentInsets={false}
          initialListSize={20}
          pageSize={20}
+          ref="flatListRef"


String ref was deprecated a year ago, you should use callback refs only.

ref={flatListRef => if (flatListRef) { this.flatListRef = flatListRef } }

brunolemos · 2018-01-17T13:18:01Z

src/MessageContainer.js

+          renderItem={this.renderRow}
+          renderHeader={this.renderFooter}
+          renderFooter={this.renderLoadEarlier()}
+          style={{ transform: [{ scaleY: -1 }, { perspective: 1280 }] }}


brunolemos · 2018-01-17T13:18:27Z

src/MessageContainer.js

-    justifyContent: 'flex-end',
+  headerWrapper: {
+    flex: 1,
+    transform: [{ scaleY: -1 }, { perspective: 1280 }],


brunolemos · 2018-01-17T13:19:22Z

src/__tests__/__snapshots__/MessageContainer.test.js.snap

    pageSize={20}
-    renderFooter={[Function]}
+    renderFooter={null}


brunolemos · 2018-01-17T13:23:49Z

src/__tests__/__snapshots__/MessageContainer.test.js.snap

+            "scaleY": -1,
+          },
+          Object {
+            "perspective": 1280,


brunolemos · 2018-01-17T13:24:05Z

src/__tests__/__snapshots__/MessageContainer.test.js.snap

+                  "scaleY": -1,
+                },
+                Object {
+                  "perspective": 1280,


brunolemos

I found very weird that the code transform: [{ scaleY: -1 }, { perspective: 1280 }] appears at least 4 times in this PR and I'm not sure why they are necessary. Maybe this can be optimized? Implemented differently?

xcarpentier · 2018-01-24T11:20:21Z

Thanks, @brunolemos I removed this style transform: [{ scaleY: -1 }, { perspective: 1280 }]

xcarpentier · 2018-01-24T11:21:37Z

Thanks @brunocascio, I removed state and extends PureComponent

brunolemos

Here is another issue that only happens on this branch.

If there are no messages and you tap the TextInput, the TextInput won't move up, it will stay below the keyboard.

If there are messages, it works as expected.

The third image shows the issue. The second image if from the live version.

Does anyone know what caused this one?

brunolemos · 2018-05-15T05:52:49Z

src/MessageContainer.js

+          contentContainerStyle={styles.contentContainerStyle}
+          renderItem={this.renderRow}
+          renderHeader={this.renderFooter}
+          renderFooter={this.renderLoadEarlier}


Why is renderHeader=renderFooter and renderFooter=renderLoadEarlier? 🤪

howg0924 · 2018-05-15T07:43:31Z

@brunolemos as for the TextInput does not move up problem, I fixed it in my fork, maybe you could take it as a reference: howg0924@06e78be

I solved it by calling keyboard listeners directly in GiftedChat.js. I don't understand why these listeners were passed down to the FlatList in MessageContainer.js.

The problem only happens on iOS on my app.

brunolemos · 2018-05-15T08:51:55Z

@howg0924 unfortunately cherry-picking this commit did not solve the issue... maybe because your branch is outdated?

howg0924 · 2018-05-15T16:16:21Z

@brunolemos: My fork is not outdated on this branch. I also fixed some other issues and did a little enhancement on my fork. I guess maybe these modification also helped to fixed the issue. Or maybe the root cause of your problem is different from mine.

brunolemos · 2018-05-15T16:36:30Z

@howg0924 yeah I merged master on it, maybe it was that

b4stien · 2018-05-21T07:07:45Z

Hello everyone, I am not sure what's blocking this PR, can we help in any way?

We're using this project at my company and would be willing to help land this (which seems to be fixing a rendering issue with messages not appearing until scroll).

xcarpentier · 2018-05-21T13:11:04Z

@b4stien some performance issue. Need to add some suc and maybe change some pure component

sibelius · 2018-05-29T17:51:36Z

@FaridSafi can we merge this, and track some regression in new issues?

xcarpentier · 2018-05-29T18:23:13Z

@sibelius I will merge it tomorrow.

helielson · 2018-05-29T19:56:17Z

Nice @xcarpentier! Can't wait! Let me know if you need any help

socksrust · 2018-05-30T16:33:41Z

awesome PR!! Thanks @xcarpentier pretty sure this will help a lot of devs!

dead23angel · 2018-05-30T17:09:49Z

bump version pls

varungupta85 · 2018-05-30T22:52:46Z

src/InputToolbar.js

-    this.setState({
-      position: 'relative',
-    });
+    if (this.state !== 'relative') {


Should this be this.state.position? Same for the if condition in keyboardWillHide also.

This is probably what caused this bug: #705 (review)

fbartho · 2018-05-30T22:57:31Z

@varungupta85 that bug looks like it just got merged into master!

* r_master: Move listViewProps to the end (FaridSafi#882) chore(package): update react-test-renderer to version 16.4.0 (FaridSafi#868) chore(package): update babel-jest to version 23.0.0 (FaridSafi#869) Update and Fix Slack Example (FaridSafi#895) Remove prop removeClippedSubviews on Flatlist (FaridSafi#897) Update Chatkit readme.md Fix typos in TS Types (FaridSafi#877) Modified for flatlist (from FaridSafi#629) (FaridSafi#705) fix tabs ignore example folder Add Chatkit asset to README.md Add Chatkit banner asset chore(package): update react-test-renderer to version 16.3.2 (FaridSafi#829) Update README.md (FaridSafi#827) add image beacon to readme chore(package): update react-test-renderer to version 16.3.1 (FaridSafi#821) # Conflicts: # .eslintignore # src/MessageContainer.js

ChrisEdson · 2018-06-18T20:50:44Z

Is it possible to get a release with the new flat list design?

glebez · 2018-06-28T09:33:58Z

Is it just me, or rednerFooter prop of gifted chat stopped properly working after this branch has been merged?

On first sight it seems to me, that FlatList does not expect props renderHeader and renderFooter, but instead ListHeaderComponent and ListFooterComponent, which makes them be ignored.

xcarpentier · 2018-06-28T11:29:17Z

@glebez Do you have any screenshot or code to share?
Or maybe think about create a PR with the fix...

sibelius · 2018-06-28T11:30:05Z

We should have an issue with all possible regressions of this PR

glebez · 2018-06-28T11:41:39Z

@xcarpentier, I'll try to put together a reduced test case first and afterwards a PR.

glebez · 2018-06-28T12:30:12Z

Here's a test case using current npm package, so before the FlatList was introduced and the footer is displayed properly: https://snack.expo.io/@glebkost/listview-example

If you change the package to use current master the footer is not displayed. (Unfortunately it's not possible in expo snack to set the package to github url, so you need to copy the snack to your local env to test that).

nandiniparimi1107 · 2018-12-31T00:27:41Z

@glebez Did we ever find a solution for this?

Darren Liew and others added 4 commits November 6, 2017 17:29

Modified for FlatList

10b8e6a

Removed invertible-scroll-view from the dependencies

33dc31f

chore(lint): merge some new lint

1ea1775

chore(test): update jest snapshot

8ff8f3a

xcarpentier changed the title ~~Modified for flatlist~~ Modified for flatlist (from #629) Jan 15, 2018

xcarpentier mentioned this pull request Jan 15, 2018

Modified for FlatList #629

Closed

xcarpentier requested a review from cooperka January 16, 2018 15:26

xcarpentier added the waiting-review label Jan 16, 2018

cooperka removed their request for review January 16, 2018 15:47

xcarpentier requested a review from brunocascio January 16, 2018 16:18

xcarpentier self-assigned this Jan 17, 2018

brunolemos suggested changes Jan 17, 2018

View reviewed changes

brunolemos reviewed Jan 17, 2018

View reviewed changes

xcarpentier added 8 commits January 23, 2018 17:48

feat(purecomponent): remove state and weird styles

6786177

fix(test): update snapshot

e1cc214

fix(state): remove state at all

c41b64d

fix(hash): try without

43b57fa

fix(hash): re-add hash for local test

d7e8718

fix(ref): undefined on scroll

761126d

chore(appr): get mine

a490305

feat(expo): change splash screen

0fea254

chore(sentry): add sentry to debug crash

3903cd9

brunolemos suggested changes May 15, 2018

View reviewed changes

brunolemos reviewed May 15, 2018

View reviewed changes

sibelius approved these changes May 29, 2018

View reviewed changes

Merge branch 'master' into modified-for-flatlist

b55d841

xcarpentier merged commit c143b5f into master May 30, 2018

varungupta85 reviewed May 30, 2018

View reviewed changes

glebez mentioned this pull request Jun 28, 2018

fix: enable renderFooter for FlatList MessageContainer #914

Merged

xcarpentier deleted the modified-for-flatlist branch May 7, 2020 07:26

Modified for flatlist (from #629) #705

Modified for flatlist (from #629) #705

Conversation

xcarpentier commented Jan 15, 2018

codecov bot commented Jan 15, 2018 • edited Loading

Codecov Report

xcarpentier commented Jan 16, 2018

cooperka commented Jan 16, 2018

brunocascio commented Jan 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brunolemos left a comment • edited Loading

Choose a reason for hiding this comment

xcarpentier commented Jan 24, 2018

xcarpentier commented Jan 24, 2018

brunolemos left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howg0924 commented May 15, 2018 • edited Loading

brunolemos commented May 15, 2018

howg0924 commented May 15, 2018

brunolemos commented May 15, 2018

b4stien commented May 21, 2018

xcarpentier commented May 21, 2018

sibelius commented May 29, 2018

xcarpentier commented May 29, 2018

helielson commented May 29, 2018

socksrust commented May 30, 2018

dead23angel commented May 30, 2018

varungupta85 May 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbartho commented May 30, 2018

ChrisEdson commented Jun 18, 2018

glebez commented Jun 28, 2018

xcarpentier commented Jun 28, 2018

sibelius commented Jun 28, 2018

glebez commented Jun 28, 2018

glebez commented Jun 28, 2018

nandiniparimi1107 commented Dec 31, 2018

codecov bot commented Jan 15, 2018 •

edited

Loading

brunocascio commented Jan 16, 2018 •

edited

Loading

brunolemos left a comment •

edited

Loading

brunolemos left a comment •

edited

Loading

howg0924 commented May 15, 2018 •

edited

Loading

varungupta85 May 30, 2018 •

edited

Loading