Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpperCamelCase naming strategy to EnumNamingStrategies #4663

Closed
lbenedetto opened this issue Aug 15, 2024 · 4 comments
Closed

Add UpperCamelCase naming strategy to EnumNamingStrategies #4663

lbenedetto opened this issue Aug 15, 2024 · 4 comments
Labels
2.19 Issues planned at 2.19 or later duplicate Duplicate of an existing (usually earlier) issue enum Related to handling of Enum values

Comments

@lbenedetto
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Some APIs I deal with use UpperCamelCase naming strategy for Enums. I can provide my own custom implementation of EnumNamingStrategy, but this is annoying.

Describe the solution you'd like

It would be nice if EnumNamingStrategy provided an UpperCamelCase strategy in addition to the lowerCamelCase strategy it currently provides.

This aligns more closely with PropertyNamingStrategy, which provides many common naming strategies, including UpperCamelCase and lowerCamelCase

Usage example

@EnumNaming(EnumNamingStrategies.UpperCamelCaseStrategy.class)

Additional context

I have provided an implementation pull request here
#4660

@lbenedetto lbenedetto added the to-evaluate Issue that has been received but not yet evaluated label Aug 15, 2024
@cowtowncoder cowtowncoder added enum Related to handling of Enum values 2.18 and removed to-evaluate Issue that has been received but not yet evaluated labels Aug 16, 2024
@cowtowncoder cowtowncoder changed the title Add UpperCamelCase naming strategy to EnumNamingStrategies Add UpperCamelCase naming strategy to EnumNamingStrategies Aug 16, 2024
@cowtowncoder
Copy link
Member

Was hoping for a new PR, as this is a good addition. But will probably not be able to get it merged in 2.18.0 due to imminent 2.18.0-rc1 release. May go in 2.19 branch when that opens.

@lbenedetto
Copy link
Contributor Author

I'll open a new PR when I find some time.

@cowtowncoder
Copy link
Member

Sounds good, no rush.

Depending on timing, can still do it against 2.18 -- whatever is the latest open 2.x branch at the time.

@cowtowncoder cowtowncoder added 2.19 Issues planned at 2.19 or later and removed 2.18 labels Oct 2, 2024
@cowtowncoder
Copy link
Member

While technically earlier, will close as dup in favor of #4676 to keep release notes simple.

@cowtowncoder cowtowncoder added the duplicate Duplicate of an existing (usually earlier) issue label Oct 2, 2024
@cowtowncoder cowtowncoder closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.19 Issues planned at 2.19 or later duplicate Duplicate of an existing (usually earlier) issue enum Related to handling of Enum values
Projects
None yet
Development

No branches or pull requests

2 participants