Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Smile format module use of ThreadLocal to be bound to SmileFactory #393

Closed
cowtowncoder opened this issue Sep 14, 2023 · 1 comment

Comments

@cowtowncoder
Copy link
Member

Currently Smile format module uses ThreadLocal for buffer recycling, both for parser and generators. Although eventually it'd be good to make this pluggable, similar to work in jackson-core, it makes sense to start by refactoring to unify handling so it's driven by SmileFactory and not by parser/generator classes.

@cowtowncoder
Copy link
Member Author

Ok, implemented. One less ThreadLocal, things bit more isolated. But the next step is trickier, need to think it through -- ideally jackson-cores BufferRecycler and BufferRecyclerPool could be used somehow but we'll see how that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant