-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Smile format module use of ThreadLocal
to be bound to SmileFactory
#393
Comments
cowtowncoder
added a commit
that referenced
this issue
Sep 15, 2023
cowtowncoder
added a commit
that referenced
this issue
Sep 15, 2023
cowtowncoder
added a commit
that referenced
this issue
Sep 15, 2023
cowtowncoder
added a commit
that referenced
this issue
Sep 15, 2023
cowtowncoder
added a commit
that referenced
this issue
Sep 15, 2023
cowtowncoder
added a commit
that referenced
this issue
Sep 15, 2023
Ok, implemented. One less |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently Smile format module uses
ThreadLocal
for buffer recycling, both for parser and generators. Although eventually it'd be good to make this pluggable, similar to work injackson-core
, it makes sense to start by refactoring to unify handling so it's driven bySmileFactory
and not by parser/generator classes.The text was updated successfully, but these errors were encountered: