-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CsvSchema skipFirstDataRow & useHeader #176
Comments
At this point, assumption is that if there is header line, that would be the very first line; this is suggested by term "data" in In theory we could add yet another feature for something like "always skip first line", but I suspect it would be easier to just create and use a |
I think that makes sense, the property is called skipFirstDataRow and not skipFirstLine. However |
@edgarklerks I am open to a configuration option, but my main concern is just whether addition can be
And I guess the only possible confusing case would be "Skip first line of file" + "no header" + "skip first data line" which should mean "skip first 2 lines of file", basically. |
I understand your point and adding an option that signals that this is an excel file and should be treated differently is also not very elegant, that gets tedious quickly if you have a lot of vendors to support. |
Perhaps an option that signals that the csv being read specifies it's own separator? Like hasSeparatorHeader? |
@edgarklerks not quite sure what |
When both skipFirstDataRow and useHeader value are set true, the skipping will take place on the second line of the document.
whether the first data line (either first line of the document, if useHeader=false, or second, if useHeader=true) should be completely ignored by parser.
Is it possible to overwrite this behaviour? Namely skipping the first line and use the second line as the header.
For example, this kind of document:
sep=,
header1,header2
value1,value2.
The text was updated successfully, but these errors were encountered: