Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(yaml) Redesign StringQuotingChecker added in 2.12 #252

Open
cowtowncoder opened this issue Apr 9, 2021 · 0 comments
Open

(yaml) Redesign StringQuotingChecker added in 2.12 #252

cowtowncoder opened this issue Apr 9, 2021 · 0 comments
Labels
yaml Issue related to YAML format backend

Comments

@cowtowncoder
Copy link
Member

Looks like I severely under-designed StringQuotingChecker so that:

  1. Handler is not passed enough pertinent information about either output context or generator configuration
  2. Handler can only give "yes"/"no" style decision on whether to use "double quotes" or something else (likely "plain"); but underlying SnakeYAML has up to 5 options (double/single-quoted, literal, folder, plan)

It would be better to solve these, and although this may be tricky to implement with full backwards-compatibility, I think it can in practice be done without problems for 2.13 -- initial implementation is so limiting that it probably isn't very useful to anyone as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
yaml Issue related to YAML format backend
Projects
None yet
Development

No branches or pull requests

1 participant