From 3f1dbd0605ce5ae22034a11736473e42c4ce79e8 Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 16 Jul 2020 05:51:47 +0100 Subject: [PATCH 1/6] build(travis): add test step --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 0957b4a1..7e82efd2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,7 +22,7 @@ branches: - /^v\d*\.\d*\.\d*$/ - /^dependabot/.*$/ -script: echo "Running tests against $(node -v)..." +script: echo "Running tests against $(node -v)..." && yarn test jobs: include: From ba5d2319a5c67098c9070db70eac819d0df18a1c Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 16 Jul 2020 05:54:31 +0100 Subject: [PATCH 2/6] build(travis): replace api_token alias to pass config validation --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 7e82efd2..c45342e2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,7 +36,7 @@ jobs: deploy: provider: npm email: devfrazs@outlook.com - api_key: + api_token: secure: nqrKpbaiRCy6XvkFQFWnx50PQ51CSvZN+u+Je7SZS9qKQproXTgdfrrui+jHuasuWJzJsKzbTy2Q+WglDvYxpS/O5kyHV2MiDj/4+wEMNUNZZRpbiBOPBvp5Y8laCC6OP+sWGPBTEhyNSvEvT9O27CgQRv/cilZRrYfNPEjNWyZ65srXAHHAu8DdX0kJpnVHlSitqUgrx5pEo/DUV3S7mAfSDueRlvbcM/bgzPAsmochKmN5rFD7rSRfTRGPLa0wZ073tz2RkS/21DlRNCfeqZKleq4kUf8ZhJQx2yi/OdE4rUVeT8pyCxFSDQJ63G6kIdyl5nCqaueiBHiV/xSseQBi6yhC67q1jFjeM6bJMdUYESkiK0T3L8QMbE5p2iK3EkC9A423R5QCXM7B/5Pjc2P8Mf934VJVx40Nl78wxPEteYf1CJcyfkDPGJ8Wbw2C2w7V0NVw7gceYnd9T1MlG9qZOi9ksfv1VD6O060SZZnD1iYc1v82lEfHcTBq+XVax/RjmVgrd6HKipV6oJa1TEpC82FwQWFS2XtNewi7UlvFEnQHmVTrm3nPGoMUS9p1AeFH61QPSl90ijmIKYme9z+zQ9g4/S7kmmE2Ozhet6r4eWtwlmIZ6PGo/k32Z/kHAMHgslokpc8OCuGhKIcxUZ23FkM43Ef6Ow7Hy/GspS4= on: tags: true \ No newline at end of file From bb1112bc79a53808c79025396e4908a40c0990c6 Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 16 Jul 2020 12:55:21 +0100 Subject: [PATCH 3/6] tests(index): use os platform when testing constructor --- src/index.test.js | 36 +++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/src/index.test.js b/src/index.test.js index feb703aa..0fa0fe95 100644 --- a/src/index.test.js +++ b/src/index.test.js @@ -1,5 +1,6 @@ const fs = require('fs'); const glob = require('glob'); +const os = require('os'); const path = require('path'); const { Poppler } = require('./index'); @@ -28,13 +29,34 @@ describe('Constructor', () => { }); test('Should convert PDF file to SVG file with binary path set', async () => { - const testPath = path.join( - __dirname, - 'lib', - 'win32', - 'poppler-0.89.0', - 'bin' - ); + const platform = os.platform(); + let testPath; + + switch (platform) { + // Windows OS + case 'win32': + default: + testPath = path.join( + __dirname, + 'lib', + 'win32', + 'poppler-0.89.0', + 'bin' + ); + break; + + // macOS + case 'darwin': + testPath = path.join( + __dirname, + 'lib', + 'darwin', + 'poppler-0.89.0', + 'bin' + ); + break; + } + const poppler = new Poppler(testPath); const options = { svgFile: true From 1d54b6a19dda65bc5b4516d16550549a5ee9f6cb Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 16 Jul 2020 12:56:11 +0100 Subject: [PATCH 4/6] chore(package): update description --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2747fd36..72db4c4d 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "node-poppler", "version": "1.7.4", - "description": "Node.js wrapper for the Poppler PDF rendering library", + "description": "Asynchronous node.js wrapper for the Poppler PDF rendering library", "keywords": [ "async", "pdf", From 183bf02a003a2b58d03191574ebc75a895bc7e6f Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 16 Jul 2020 13:41:19 +0100 Subject: [PATCH 5/6] build(travis): set linux dist --- .travis.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index c45342e2..34731cf6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,6 +2,8 @@ language: node_js cache: yarn +dist: bionic + node_js: - 'lts/*' - 'node' @@ -34,9 +36,9 @@ jobs: node_js: lts/* os: linux deploy: - provider: npm - email: devfrazs@outlook.com - api_token: - secure: nqrKpbaiRCy6XvkFQFWnx50PQ51CSvZN+u+Je7SZS9qKQproXTgdfrrui+jHuasuWJzJsKzbTy2Q+WglDvYxpS/O5kyHV2MiDj/4+wEMNUNZZRpbiBOPBvp5Y8laCC6OP+sWGPBTEhyNSvEvT9O27CgQRv/cilZRrYfNPEjNWyZ65srXAHHAu8DdX0kJpnVHlSitqUgrx5pEo/DUV3S7mAfSDueRlvbcM/bgzPAsmochKmN5rFD7rSRfTRGPLa0wZ073tz2RkS/21DlRNCfeqZKleq4kUf8ZhJQx2yi/OdE4rUVeT8pyCxFSDQJ63G6kIdyl5nCqaueiBHiV/xSseQBi6yhC67q1jFjeM6bJMdUYESkiK0T3L8QMbE5p2iK3EkC9A423R5QCXM7B/5Pjc2P8Mf934VJVx40Nl78wxPEteYf1CJcyfkDPGJ8Wbw2C2w7V0NVw7gceYnd9T1MlG9qZOi9ksfv1VD6O060SZZnD1iYc1v82lEfHcTBq+XVax/RjmVgrd6HKipV6oJa1TEpC82FwQWFS2XtNewi7UlvFEnQHmVTrm3nPGoMUS9p1AeFH61QPSl90ijmIKYme9z+zQ9g4/S7kmmE2Ozhet6r4eWtwlmIZ6PGo/k32Z/kHAMHgslokpc8OCuGhKIcxUZ23FkM43Ef6Ow7Hy/GspS4= - on: - tags: true \ No newline at end of file + provider: npm + email: devfrazs@outlook.com + api_token: + secure: nqrKpbaiRCy6XvkFQFWnx50PQ51CSvZN+u+Je7SZS9qKQproXTgdfrrui+jHuasuWJzJsKzbTy2Q+WglDvYxpS/O5kyHV2MiDj/4+wEMNUNZZRpbiBOPBvp5Y8laCC6OP+sWGPBTEhyNSvEvT9O27CgQRv/cilZRrYfNPEjNWyZ65srXAHHAu8DdX0kJpnVHlSitqUgrx5pEo/DUV3S7mAfSDueRlvbcM/bgzPAsmochKmN5rFD7rSRfTRGPLa0wZ073tz2RkS/21DlRNCfeqZKleq4kUf8ZhJQx2yi/OdE4rUVeT8pyCxFSDQJ63G6kIdyl5nCqaueiBHiV/xSseQBi6yhC67q1jFjeM6bJMdUYESkiK0T3L8QMbE5p2iK3EkC9A423R5QCXM7B/5Pjc2P8Mf934VJVx40Nl78wxPEteYf1CJcyfkDPGJ8Wbw2C2w7V0NVw7gceYnd9T1MlG9qZOi9ksfv1VD6O060SZZnD1iYc1v82lEfHcTBq+XVax/RjmVgrd6HKipV6oJa1TEpC82FwQWFS2XtNewi7UlvFEnQHmVTrm3nPGoMUS9p1AeFH61QPSl90ijmIKYme9z+zQ9g4/S7kmmE2Ozhet6r4eWtwlmIZ6PGo/k32Z/kHAMHgslokpc8OCuGhKIcxUZ23FkM43Ef6Ow7Hy/GspS4= + on: + tags: true From 3fb542f9a21c06c858b3e38cb72286478e949b03 Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 16 Jul 2020 15:23:09 +0100 Subject: [PATCH 6/6] build(travis): suppress git log; skip rerunning tests on deploy --- .travis.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 34731cf6..546b1aeb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,9 @@ cache: yarn dist: bionic +git: + quiet: true + node_js: - 'lts/*' - 'node' @@ -28,13 +31,16 @@ script: echo "Running tests against $(node -v)..." && yarn test jobs: include: - - stage: Produce Coverage + - stage: test + name: produce coverage node_js: lts/* os: windows script: jest --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage - - stage: NPM release + - stage: deploy + name: NPM release node_js: lts/* os: linux + script: skip deploy: provider: npm email: devfrazs@outlook.com