Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messed up styles with logs #154

Closed
AbhimanyuAryan opened this issue Aug 31, 2022 · 8 comments
Closed

messed up styles with logs #154

AbhimanyuAryan opened this issue Aug 31, 2022 · 8 comments

Comments

@AbhimanyuAryan
Copy link
Contributor

AbhimanyuAryan commented Aug 31, 2022

I think something is messing up the styles of my Genie/Stipple logs

With Term.jl
Screenshot 2022-08-31 at 12 21 53 PM
Screenshot 2022-08-31 at 12 22 12 PM

Without Term.jl

Screenshot 2022-08-31 at 12 23 38 PM

Code to reproduce this:

https://github.com/GenieFramework/StippleDemos/tree/master/BasicExamples/CSVUploadProcess

$ julia --project 
pkg> instantiate
julia> include("CSVUploadProcess.jl")
@AbhimanyuAryan
Copy link
Contributor Author

boxes don't are messing up styles I believe

buggy code you can test to reproduce

@with_repr struct OrderedPair
       x::Real
       y::Real
       z::Real
       OrderedPair(x,y) = x > y ? error("out of order") : new(x,y)
end

OrderedPair(1,2)

Screenshot 2022-09-04 at 10 16 17 PM
Screenshot 2022-09-04 at 10 16 26 PM

Screenshot 2022-09-04 at 10 16 34 PM

@AbhimanyuAryan AbhimanyuAryan changed the title messed up styles with Genie logs messed up styles with logs Sep 4, 2022
@FedeClaudi
Copy link
Owner

Hey, is this with the latest version? This should be better now compared to the previous release (although not perfect yet)

@AbhimanyuAryan
Copy link
Contributor Author

Will check and let you know 💜

@AbhimanyuAryan
Copy link
Contributor Author

yes those are the issues with 1.0.4
If possible please try to run the demo I provided to see it yourself

@AbhimanyuAryan
Copy link
Contributor Author

@FedeClaudi is this indentation intended?

Screenshot 2022-09-19 at 5 16 25 PM

@FedeClaudi
Copy link
Owner

I think so, but perhaps it would look better without?

@AbhimanyuAryan
Copy link
Contributor Author

@FedeClaudi I would like to tag a friend @esterbvila who's a UI/UX expert maybe she can drop in some suggestions here :)

@esterbvila
Copy link

@FedeClaudi I would suggest to not indent it and maybe try to change words like "Copied", "to" and "Created" to another color, to distinguish them from the urls. It could be another shade of blue, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants