-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support white background terminals #156
Comments
Hey, Thanks for opening this issue, it's a very good point. It seems like a fairly easy fix, perfect for someone that wants to actively contribute to Term 😄 |
Interested, yes 😀. Available, probably not (or at least I shouldn't). Maybe I won't be able to help myself, so let's see. But if someone else wants to jump in, it would save me from the procrastination hole. 😉 |
Hahah, it seems like we're on the same boat here! Let's leave it open and see who gives in first 😉 |
Fixed by #158 |
This library assumes that it is being used in a dark background terminal.
It would be great to be able to use it in white background terminal:
There seem to be many hard-code color values, for example, the name of the scheme being printed in white in the above screenshot, from here:
Term.jl/src/theme.jl
Lines 94 to 105 in 4ab195d
Similarly, there are lots of hard-coded values in
errors.jl
andlogs.jl
, which unfortunately makes the otherwise very niceinstall_term_logger
andinstall_term_stacktrace
impossible to use. All of these colors should refer to something configurable in the color schemeThere should be a switch to turn off all color, for monochrome or reduced-color terminals. The framed backtraces and such would be quite nice to have, but they should be rendered black on white (or white on black) in such environments
It would be nice to have a built-in colorscheme that is tested for readability on white background terminals.
The cherry on top would be to detect the background color of the terminal (e.g. via the
COLORFGBG
environment variable) and to choose the default scheme based on that.The text was updated successfully, but these errors were encountered: