Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 pre-release issues #201

Closed
6 tasks done
FedeClaudi opened this issue Feb 10, 2023 · 5 comments · Fixed by #204
Closed
6 tasks done

v2.0 pre-release issues #201

FedeClaudi opened this issue Feb 10, 2023 · 5 comments · Fixed by #204
Assignees
Labels

Comments

@FedeClaudi
Copy link
Owner

FedeClaudi commented Feb 10, 2023

Noting problems while testing initial release of v2.0

  • intermitted error message display
  • progress bar with :detailed columns too wide.
  • logging doesnt show array size and doesn't trim stuff. Tuples have weird shape
  • MethodError: no method matching frame_module(::Tuple) when rendering errors
  • improvements to progress bar styling: Feature request: improved Progressbar styling options - color/line style. #202 and docstrings
  • errors file links not working correctly (see below)
@FedeClaudi FedeClaudi added the v2 label Feb 10, 2023
@FedeClaudi FedeClaudi self-assigned this Feb 10, 2023
@VarLad
Copy link

VarLad commented Feb 17, 2023

@FedeClaudi Any idea if its possible to change the file link here to the actual (full) filename, instead of relative filename?
image

@FedeClaudi
Copy link
Owner Author

thanks for getting in touch. Yeah, I was trying to save some terminal real-estate with these shortened links but it might be better to have the full thing.

@VarLad
Copy link

VarLad commented Feb 17, 2023

@FedeClaudi I meant, you can keep the display name as ./reduce.jl 95, but clicking on it should point to the full path of reduce.jl
image

Kind like this, this is from another CLI program though

I believe Link is being used to do this in Term.jl?

@FedeClaudi
Copy link
Owner Author

oh I see. In theory the stacktrace is using Link but it doesn't seem to be working. I'll look into it. It also seems like not all terminals support ANSI link syntax.

@FedeClaudi FedeClaudi linked a pull request Feb 18, 2023 that will close this issue
2 tasks
@FedeClaudi
Copy link
Owner Author

All changes listed above have been implemented. #204 will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants