Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Image preview/display #17

Open
Tracked by #37
ic-it opened this issue Jun 5, 2024 · 6 comments
Open
Tracked by #37

[feature]: Image preview/display #17

ic-it opened this issue Jun 5, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@ic-it
Copy link

ic-it commented Jun 5, 2024

Is your feature request related to a problem? Please describe.
It would be cool to have a preview or full image display using iTerm/Kitty graphics protocol.

Describe the solution you'd like
There is already a rust solution that knows how to display an image. https://github.com/atanunq/viu
It might be the base

@ic-it ic-it added the enhancement New feature or request label Jun 5, 2024
@FedericoBruzzone
Copy link
Owner

Thank you for this feature request @ic-it.

We were already considering adding the image preview feature using the ratatui-image crate, as you can see here, at the end of the file.

However, due to the fact that Ratatui had a problem displaying Unicode characters when the length was greater than 1, we had put aside this feature. We could not use ratatui-image due to a dependency resolution problem described in the Cargo book. At that time, we were pointing to a commit on a forked Ratatui repository.

We are currently in the process of an alpha release, so this feature and audio support will be included in the beta release. We will certainly consider using your suggested library.

@ralencode
Copy link

what about image to ascii converters? they'll definitely work everywhere and are better than nothing

@FedericoBruzzone
Copy link
Owner

I am slightly caught up in a lot of work at present.
As soon as I can, that's the first thing I'm going to do!

@benjajaja
Copy link

@FedericoBruzzone if you need anything from ratatui-image in terms of dependency resolution, I'd love to fix any problems on ratatui-image's part.

@FedericoBruzzone
Copy link
Owner

@FedericoBruzzone if you need anything from ratatui-image in terms of dependency resolution, I'd love to fix any problems on ratatui-image's part.

Thank you for your helpfulness! I'm a little bit busy at the moment, but as soon as I can I'll get working on this and any problems I'll be glad to help you fix it!

@benjajaja
Copy link

For future reference, hopefully the dependency resolution is fixed in ratatui-image since benjajaja/ratatui-image#35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants