Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase NVIDIA overclock limit #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anuskuss
Copy link

@Anuskuss Anuskuss commented Nov 7, 2024

Personally I'm against this hand-holding (you already require root permissions to overclock at all) and think that the whole block of code gotta go but if you wanna keep this at least use some more realistic numbers. I can personally do 140/2790 (150 clock crashes, 2800 vram has artifacts) but I've seen people comfortably at 250 clock so 300 should be a good upper bound.
I would also suggest that instead of failing at all to just do a max(config_get_nv_core_clock_mhz_offset(), 300) but that would require a few more changes.

@afayaz-feral
Copy link
Contributor

afayaz-feral commented Dec 9, 2024

I agree that the hardcoded limit is unnecessary, and I assume the original author picked those specific values based on the hardware available at the time. Increasing the limit doesn't really solve the underlying problem.

I've been investigating the consequences of removing the limit altogether. I'll keep this PR open for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants