-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ferrite.nfields
should be called differently
#444
Comments
Addressed in #486 because it has been an issue several times. |
termi-official
pushed a commit
that referenced
this issue
Mar 29, 2023
fredrikekre
pushed a commit
that referenced
this issue
Apr 1, 2023
This patch deprecates the internal function `nfields(dh)` in favor of `length(getfieldnames(dh))`. The reason is twofold: `nfields` where barely used, not even internally, and `nfields` was easy to confuse with the existing `Base.nfields` function that would still work, but behave quite differently. Closes #444.
fredrikekre
pushed a commit
that referenced
this issue
Apr 1, 2023
This patch deprecates the internal function `nfields(dh)` in favor of `length(getfieldnames(dh))`. The reason is twofold: `nfields` where barely used, not even internally, and `nfields` was easy to confuse with the existing `Base.nfields` function that would still work, but behave quite differently. Closes #444.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The first one calls Julias
nfields
.The text was updated successfully, but these errors were encountered: