Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Benchmarks #36

Open
SkyeHoefling opened this issue Jan 24, 2022 · 2 comments · May be fixed by #42
Open

Fix Benchmarks #36

SkyeHoefling opened this issue Jan 24, 2022 · 2 comments · May be fixed by #42
Assignees

Comments

@SkyeHoefling
Copy link
Contributor

Description

The benchmarks started failing from PR #31 which doesn't make complete sense as that was just github templates.

Expected Behavior

Ensure benchmarks run successfully

Steps To Reproduce

There are a couple way to run the benchmarks

  • Submit a PR and wait for benchmarks to run (this will run the benchmarks from your current branch)
  • Using the /benchmark command in any PR (this will run the benchmark.yml from the main branch, but invoke the benchmarks from your current branch)

Environment

- CI
@Bett-A-Fish
Copy link
Contributor

I found this which looks to be a very similar issue to ours: actions/checkout#36

@SkyeHoefling
Copy link
Contributor Author

@Bett-A-Fish thanks for the mind push - I just fixed this in fileonq/imaging.heif to support benchmarking on forked repositories. I pushed a lot of my changes straight to main to fix that because of how the benchmarking works. As far as I understand we will need to update the GitHub action to capture the correct ref and pass that to the various jobs. See the code below

https://github.com/FileOnQ/Imaging.Heif/blob/3c0f5b1f4d07534bf7dd35f8ace4155883b0b0d9/.github/workflows/benchmark.yml#L33-L56

Do you want to take a look and PR this? If so I can assign this one to you

@kenny-sellers kenny-sellers linked a pull request Jan 28, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants