New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the http status code handling on upnp (Triage on ostracon#497) #11

Closed

Tracked by

0Tech opened this issue Nov 1, 2023 · 1 comment

Closed

Tracked by

Update the http status code handling on upnp (Triage on ostracon#497) #11

0Tech opened this issue Nov 1, 2023 · 1 comment

Assignees

0Tech commented Nov 1, 2023 •

edited by Mdaiki0730

Loading

The subject of the triage:

fix: Update the http status code handling on upnp ostracon#497

0Tech mentioned this issue

EPIC: triage the PRs from Finschia/ostracon #1

Open

50 tasks

0Tech assigned Mdaiki0730

Member

Mdaiki0730 commented Nov 2, 2023

It seems that p2p/upnp/upnp.go does not exist at the stage of v0.38.0.
https://github.com/cometbft/cometbft/tree/v0.38.0/p2p

p2p/upnp/upnp.go was considered for removal in cometbft#1113 and removed in cometbft#1114.
cometbft#1113
cometbft#1114

It seems that there is no need to reflect it in cometbft.

Mdaiki0730 closed this as completed

Mdaiki0730 changed the title ~~Triage on ostracon#497~~ Update the http status code handling on upnp (Triage on ostracon#497)

0Tech closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment