Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KMS functionality(Triage on ostracon#417) #34

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 4 comments
Open
Tracked by #1

Add KMS functionality(Triage on ostracon#417) #34

0Tech opened this issue Nov 1, 2023 · 4 comments
Assignees
Labels

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@jaeseung-bae
Copy link

  • Opinion
    • Not to apply
  • Reason
    • Hard to apply to upstream, because upstream has their kms(tmkms)
    • We can replace ours with tmkms

@jaeseung-bae jaeseung-bae changed the title Triage on ostracon#417 Add KMS functionality(Triage on ostracon#417) Nov 6, 2023
@zemyblue
Copy link
Member

zemyblue commented Nov 13, 2023

We need to apply Finschia/finschia-sdk#821 in cosmos-sdk

@zemyblue
Copy link
Member

As far as I know, Ostracon#417 is a PR to add test code of common kms of tendermint. So I think it would be nice to apply it to cometbft.

@zemyblue
Copy link
Member

We cannot show the validator information as cli when the validator use KMS. Because createAndStartPrivValidatorSocketClient of node cannot access it in external.
https://github.com/cometbft/cometbft/blob/3b1cdce4242a67c16e8f88e4aed0fbe17d0989e0/node/setup.go#L614

So, I think it's nice to change to public function in cometbft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants