Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout configs (ostracon#150) #38

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 4 comments
Open
Tracked by #1

add timeout configs (ostracon#150) #38

0Tech opened this issue Nov 1, 2023 · 4 comments

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@loloicci
Copy link

loloicci commented Nov 6, 2023

ostracon#150

  • adds explicit settings of ReadTimeout and WriteTimeout in the rpc config
  • adds IdleTimeout as a field of the rpc config

the former is not needed by lbm, but the latter is needed by lbm. whether does the original cometbft need it or not is under researching

@loloicci
Copy link

We need to discuss whether we should suggest them.

@loloicci loloicci changed the title Triage on ostracon#150 add timeout configs (ostracon#150) Nov 15, 2023
@Mdaiki0730
Copy link
Member

I thought it would be good to consider this issue in parallel with #37.
This is because the modifications and the purpose are almost the same.

Is config an option?
If the default value is used even if it is empty, I think it would be a good idea to issue a PR.

@loloicci
Copy link

Without this PR, IdolTimeout is always as same as ReadTimeout. If WriteTimeout is shorter than it, timeout problems may happen. So I will suggest it to upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants