Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for additional app commit duration(Triage on ostracon#136) #48

Closed
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 1 comment
Closed
Tracked by #1
Assignees

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

No description provided.

@jaeseung-bae
Copy link

jaeseung-bae commented Nov 3, 2023

  • Opinion
    • Not to apply
  • Reason
    • In my opinion, not all metrics are necessary all the time.
    • How about we put custom metrics such as BlockAppCommitTime metrics.Gauge when it needs(such as performance test)

@jaeseung-bae jaeseung-bae changed the title Triage on ostracon#136 Metrics for additional app commit duration(Triage on ostracon#136) Nov 6, 2023
@jaeseung-bae jaeseung-bae closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants