Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data race error #514

Closed
4 tasks
zemyblue opened this issue Apr 22, 2022 · 1 comment · Fixed by #516
Closed
4 tasks

Data race error #514

zemyblue opened this issue Apr 22, 2022 · 1 comment · Fixed by #516
Assignees
Labels
A: bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@zemyblue
Copy link
Member

zemyblue commented Apr 22, 2022

Summary of Bug

Almost test-race test is failed after #495.
I think this data race problem is occurred by goleveldb used in Ostracon.

for example:
https://github.com/line/lbm-sdk/runs/6127657380?check_suite_focus=true

Version

after #495

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue added the A: bug Something isn't working label Apr 22, 2022
@dudong2 dudong2 mentioned this issue Apr 27, 2022
5 tasks
@tnasu tnasu assigned dudong2 and unassigned tnasu Apr 27, 2022
@zemyblue
Copy link
Member Author

This bug was not fixed.
I merged #516 into #513. And this similar bug was occurred again.

https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true

WARNING: DATA RACE
[153](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:153)
Write at 0x00c0030d7690 by goroutine 120:
[154](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:154)
  github.com/line/lbm-sdk/baseapp.(*BaseApp).BeginBlock()
[155](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:155)
      /home/runner/work/lbm-sdk/lbm-sdk/baseapp/abci.go:195 +0xf9e
[156](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:156)
  github.com/line/lbm-sdk/simapp.(*SimApp).BeginBlock()
[157](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:157)
      <autogenerated>:1 +0xf7
[158](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:158)
  github.com/line/ostracon/abci/client.(*localClient).BeginBlockSync()
[159](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:159)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/abci/client/local_client.go:295 +0x1b4
[160](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:160)
  github.com/line/ostracon/proxy.(*appConnConsensus).BeginBlockSync()
[161](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:161)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/proxy/app_conn.go:85 +0xd4
[162](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:162)
  github.com/line/ostracon/state.execBlockOnProxyApp()
[163](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:163)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/state/execution.go:383 +0x734
[164](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:164)
  github.com/line/ostracon/state.(*BlockExecutor).ApplyBlock()
[165](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:165)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/state/execution.go:169 +0x252
[166](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:166)
  github.com/line/ostracon/consensus.(*State).finalizeCommit()
[167](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:167)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:1699 +0x1056
[168](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:168)
  github.com/line/ostracon/consensus.(*State).tryFinalizeCommit()
[169](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:169)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:1610 +0x5c7
[170](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:170)
  github.com/line/ostracon/consensus.(*State).enterCommit.func1()
[171](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:171)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:1545 +0x146
[172](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:172)
  github.com/line/ostracon/consensus.(*State).enterCommit()
[173](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:173)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:1583 +0x94c
[174](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:174)
  github.com/line/ostracon/consensus.(*State).addVote()
[175](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:175)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:2251 +0x152e
[176](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:176)
  github.com/line/ostracon/consensus.(*State).tryAddVote()
[177](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:177)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:2048 +0x7c
[178](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:178)
  github.com/line/ostracon/consensus.(*State).handleMsg()
[179](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:179)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:888 +0xe56
[180](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:180)
  github.com/line/ostracon/consensus.(*State).receiveRoutine()
[181](https://github.com/line/lbm-sdk/runs/6209018884?check_suite_focus=true#step:6:181)
      /home/runner/go/pkg/mod/github.com/line/ostracon@v1.0.4/consensus/state.go:832 +0x8a4
...

@zemyblue zemyblue reopened this Apr 28, 2022
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants