Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mock field is created when simd init #770

Closed
3 of 4 tasks
zemyblue opened this issue Oct 28, 2022 · 1 comment
Closed
3 of 4 tasks

A mock field is created when simd init #770

zemyblue opened this issue Oct 28, 2022 · 1 comment
Assignees
Labels
A: bug Something isn't working

Comments

@zemyblue
Copy link
Member

zemyblue commented Oct 28, 2022

Summary of Bug

A mock field is created in app_state when simd init

mock is not module, but the field is added.

{
  "chain_id": "simd-testing",
  "consensus_params": {},
  "app_state": {

    "mint": {...},
    "mock": null,
    "params": null,
...
  }
}

Version

lbm-sdk v0.46.0-rc9

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue added the A: bug Something isn't working label Oct 28, 2022
@dudong2 dudong2 self-assigned this Oct 28, 2022
@dudong2
Copy link
Contributor

dudong2 commented Nov 2, 2022

At #651, the ibcmock module was included in the module initialization and begin block, end blocker, init genesis order.
So ,there was a bug in genesis.json including the ibcmock.

Here, I tried to remove ibcmock, but this has proven to be impossible currently.

If you look at the structure of cosmos, cosmos-sdk and ibc-go are separated from each other. And these are combined and distributed in the form of gaia.
So, cosmos-sdk doesn't need any import for ibc.

However, the structure of lbm includes ibc as a module in lbm-sdk.
Therefore, when creating a simapp, ibcmock must also be included as a module.
Because lbm doesn't need to include ibcmock, I decide it's not an issue and close.

@dudong2 dudong2 closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants