Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FromDocRef (rxfire/firestore) no longer exists/works, FromRef perhaps replaced? Typo? #32

Open
unanticipatedReturnOfTheOriginalArtForm opened this issue Sep 7, 2021 · 1 comment
Open

FromDocRef (rxfire/firestore) no longer exists/works, FromRef perhaps replaced? Typo? #32

unanticipatedReturnOfTheOriginalArtForm opened this issue Sep 7, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@unanticipatedReturnOfTheOriginalArtForm
Copy link

" import { fromDocRef } from 'rxfire/firestore'; " on my little project does not work, Perhaps a typo, as there is a FromRef which is not in the documentation for 'rxfire/firestore'.

Peace.
@jhuleatt jhuleatt added the good first issue Good for newcomers label Oct 21, 2021
@jhuleatt
Copy link
Contributor

jhuleatt commented Oct 21, 2021 •
edited
Loading

Thanks for filing this @unanticipatedReturnOfTheOriginalArtForm, it looks like fromDocRef and fromCollectionRef were consolidated into fromRef in b502277#diff-96b9a23af332e20960c8d4e0ad8221e1b9d47ff96ecf569e8db15859a1ecdd67.

Both fromDocRef and fromCollectionRef should be updated in https://github.com/FirebaseExtended/rxfire/blob/main/docs/firestore.md#event-observables

fyi @jamesdaniels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhuleatt @unanticipatedReturnOfTheOriginalArtForm