Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all shared FHIR test cases against our API #1262

Closed
wardweistra opened this issue Feb 13, 2020 · 3 comments
Closed

Run all shared FHIR test cases against our API #1262

wardweistra opened this issue Feb 13, 2020 · 3 comments

Comments

@wardweistra
Copy link
Member

It is said that currently we only run 6 of the shared FHIR test cases on the .NET API: https://github.com/FHIR/fhir-test-cases. It would likely be better for the quality of the validator to run all of them in an automated fashion.

Discussion on Zulip:

@grahamegrieve
Copy link

grahamegrieve commented Feb 13, 2020

Note - the test cases are driven from the manifest.json file. The manifest presents a test case, and then defines what the java validator does in terms of errors and warnings. Mostly, it works by count. I expect that the dotnet validator will not produce the same error messages, or even the same count, so I expect that the dotnet validator will have it's own parallel addition to each test case. But I do expect that the validators will agree about what is valid or not

I will document the format at some stage so that it's easier to get the tests working

@ewoutkramer
Copy link
Member

(text from @marcovisserFurore)

Snapshot compatibility between .NET and Java. - and Michel's/Grahame's unit-tests.

Ideas:

  • make a submodule of the repo from Grahame and perform the unittest on that
  • create a build pipeline that downloads the latest version of the data of Grahame and then perform the unittest of that

@mmsmits
Copy link
Member

mmsmits commented Feb 14, 2024

This is already in place

@mmsmits mmsmits closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants