Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Support validating codes against ValueSets contained in StructureDefinitions #129

Closed
mmsmits opened this issue Feb 4, 2021 · 1 comment
Labels
align-with-java From comparing the shared unit tests

Comments

@mmsmits
Copy link
Member

mmsmits commented Feb 4, 2021

Describe the bug
The validator should support validating codes against ValueSets contained in StructureDefinitions. There is a use case where StructureDefinitions define bindings to valuesets that are contained (referenced with a #) in that SD itself . The validator currently doesn't resolve those ValueSets and therefor can't validate codes against them.

To Reproduce
Run the RunSingleTest() test method in ValidationManifestTest.cs using patient-translated-codes in the R4 branch.

Expected behavior
The validator should be able to resolve the contained valuesets (maybe with a new ResourceResolver, like an "InstanceResolver"), and should be able to contain codes against them.

Version used:

  • FHIR Version: STU3, R4, R5

Additional context
This issue/feature has come to light comparing the Java Validator against the .NET validator.

@marcovisserFurore marcovisserFurore transferred this issue from FirelyTeam/firely-net-sdk Jul 20, 2023
@mmsmits mmsmits added the align-with-java From comparing the shared unit tests label Feb 14, 2024
@ewoutkramer
Copy link
Member

Duplicate of FirelyTeam/firely-net-sdk#1747. This needs general support from the SDK, as defined in the referred issue. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
align-with-java From comparing the shared unit tests
Projects
None yet
Development

No branches or pull requests

2 participants