Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The if-match header is now also defined on DELETE interactions. #2621

Closed
ewoutkramer opened this issue Nov 13, 2023 · 1 comment
Closed

The if-match header is now also defined on DELETE interactions. #2621

ewoutkramer opened this issue Nov 13, 2023 · 1 comment
Assignees
@Kasdejong

Comments

@ewoutkramer
Copy link
Member

https://firely.atlassian.net/browse/VONK-5627

https://jira.hl7.org/browse/FHIR-40772
@mmsmits
Copy link
Member

mmsmits commented Mar 7, 2024 •
edited
Loading

Refinement:

We should:

  • add a new overload in TransactionBuilder called
    Delete(SearchParams condition, Resource body, string? versionId = null, string? bundleEntryFullUrl = null)
    Handle the if-match header here (see Update for inspriration).

  • Also make sure the BaseFhirClient.DeleteAsync uses this new overload.

  • Add a test in the FhirClientMockTests to make sure the header is set.

@Kasdejong Kasdejong self-assigned this Mar 7, 2024
@Kasdejong Kasdejong mentioned this issue Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kasdejong Kasdejong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ewoutkramer @mmsmits @Kasdejong